You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/04/29 15:07:28 UTC

[GitHub] [calcite] zabetak commented on a change in pull request #1884: [CALCITE-2970] Performance issue when enabling abstract converter for EnumerableConvention

zabetak commented on a change in pull request #1884:
URL: https://github.com/apache/calcite/pull/1884#discussion_r417387438



##########
File path: core/src/main/java/org/apache/calcite/plan/Convention.java
##########
@@ -66,6 +67,15 @@ default boolean useAbstractConvertersForConversion(RelTraitSet fromTraits,
     return true;
   }
 
+  /**
+   * Transform a RelBuilder to support creating physical RelNode with current convention.
+   * @param oldRelBuilder The original RelBuilder to be transformed.
+   * @return A new RelBuilder after transformation.
+   */
+  default RelBuilder transformRelBuilder(RelBuilder oldRelBuilder) {

Review comment:
       Why not simply having the following method:`default RelBuilderFactory getRelFactory()`. It is more intuitive and makes the existing callers simpler.  
   Moreover, if we do this I think we can avoid adding the new getters/setters in `RelBuilder`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org