You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by asoldano <gi...@git.apache.org> on 2017/04/18 22:51:21 UTC
[GitHub] cxf pull request #262: [CXF-7339] Fix NPE due to weak reference being GC-ed
GitHub user asoldano opened a pull request:
https://github.com/apache/cxf/pull/262
[CXF-7339] Fix NPE due to weak reference being GC-ed
https://issues.apache.org/jira/browse/CXF-7339
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/asoldano/cxf CXF-7339
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/262.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #262
----
commit fe4b6e6bf85bc3881a363bb1a731b66ddf91bec3
Author: Alessio Soldano <as...@redhat.com>
Date: 2017-04-18T22:48:39Z
[CXF-7339] Fix NPE due to weak reference being GC-ed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #262: [CXF-7339] Fix NPE due to weak reference being GC-ed
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cxf/pull/262
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #262: [CXF-7339] Fix NPE due to weak reference being GC-ed
Posted by dkulp <gi...@git.apache.org>.
Github user dkulp commented on the issue:
https://github.com/apache/cxf/pull/262
I actually think doing "both" would be the right thing to do. The fix in this PR is likely correct as calling remove with a null key is pointless as there shouldn't ever be a null "Set" of classes as a key in the cache. Possibly and empty set, but likely not a null set.
However, protecting against it in the CacheMap is also a good thing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #262: [CXF-7339] Fix NPE due to weak reference being GC-ed
Posted by asoldano <gi...@git.apache.org>.
Github user asoldano commented on the issue:
https://github.com/apache/cxf/pull/262
@andymc12 I've added another commit for the changes in the CacheMap, hopefully this should be enough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #262: [CXF-7339] Fix NPE due to weak reference being GC-ed
Posted by asoldano <gi...@git.apache.org>.
Github user asoldano commented on the issue:
https://github.com/apache/cxf/pull/262
@andymc12 , actually I expected a concern about this, that's why I opened up a PR instead of committing directly. I'm not sure we want to keep the former behavior wrt supporting null keys. I don't think entries with null keys were actually used before, null keys happened to be "supported" because of the internal implementation detail choice. This said I believe the code that I fixed is not calling remove(null) on purpose, basically the change here is exposing a bug that was there before.
@dkulp what's your opinion on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #262: [CXF-7339] Fix NPE due to weak reference being GC-ed
Posted by asoldano <gi...@git.apache.org>.
Github user asoldano commented on the issue:
https://github.com/apache/cxf/pull/262
OK, thanks, I've merged the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #262: [CXF-7339] Fix NPE due to weak reference being GC-ed
Posted by dkulp <gi...@git.apache.org>.
Github user dkulp commented on the issue:
https://github.com/apache/cxf/pull/262
Yea... that looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---