You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "k-aishwarya (via GitHub)" <gi...@apache.org> on 2023/12/28 12:41:25 UTC
[PR] Adding Atimicserver config [incubator-opendal]
k-aishwarya opened a new pull request, #3845:
URL: https://github.com/apache/incubator-opendal/pull/3845
For #3240
@Xuanwo Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Adding Atomicserver config [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #3845:
URL: https://github.com/apache/incubator-opendal/pull/3845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding Atimicserver config [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3845:
URL: https://github.com/apache/incubator-opendal/pull/3845#discussion_r1437649716
##########
core/src/services/atomicserver/backend.rs:
##########
@@ -41,37 +40,72 @@ use crate::raw::AsyncBody;
use crate::raw::FormDataPart;
use crate::raw::HttpClient;
use crate::raw::Multipart;
+use crate::raw::{new_json_deserialize_error, ConfigDeserializer};
use crate::Builder;
use crate::Scheme;
use crate::*;
/// Atomicserver service support.
+
+/// Config for atomicserver services support
+#[derive(Default, Deserialize, Clone)]
+#[serde(default)]
+#[non_exhaustive]
+pub struct AtomicserverConfig {
+ /// work dir of this backend
+ pub root: Option<String>,
+ /// endpoint of this backend
+ pub endpoint: Option<String>,
+ /// private_key of this backend
+ pub private_key: Option<String>,
+ /// public_key of this backend
+ pub public_key: Option<String>,
+ /// parent_resource_id of this backend
+ pub parent_resource_id: Option<String>,
+}
+
+impl Debug for AtomicserverConfig {
+ fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+ f.debug_struct("AtomicserverConfig")
+ .field("root", &self.root)
+ .field("endpoint", &self.endpoint)
+ .field("private_key", &self.private_key)
Review Comment:
Please don't print private key in debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org