You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/07/26 04:58:02 UTC
[GitHub] [apisix-helm-chart] NMichas opened a new pull request, #316: feat: Allow `fullnameOverride`s to work correctly
NMichas opened a new pull request, #316:
URL: https://github.com/apache/apisix-helm-chart/pull/316
Purpose: Allow `fullnameOverride`s to work correctly to fully automate Helm deployments.
Note: This is an updated PR, a lot less intrusive than the one suggested in https://github.com/apache/apisix-helm-chart/pull/292 (which I have now closed).
- In APISIX admin:
If the etcd subchart is configured to use a `fullnameOverride`, APISIX admin fails to start. This is due to the fact that etcd `fullnameOverride` is not taken into account in APISIX admin's init container nor configmap. This PR is backwards compatible in the sense that if users do not use a `fullnameOverride` for etcd, the chart behaves identically as before.
- In APISIX Ingress Controller:
`apisix.serviceName` and `apisix.serviceNamespace` must be explicitly set, thus not allowing users to fully automate a Helm install when using a custom `fullnameOverride` for APISIX admin which might have a different logic than the one currently used to construct the APISIX admin URL. This PR introduces a new value `apisix.serviceFullname`. When this value is set, it is overriding the logic of constructing the APISIX admin URL from `apisix.serviceName` and `apisix.serviceNamespace`. This PR is backwards compatible in the sense that if users do not use the newly introduced `apisix.serviceFullname` value, the chart behaves identically as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] NMichas commented on pull request #316: feat: Allow `fullnameOverride`s to work correctly
Posted by GitBox <gi...@apache.org>.
NMichas commented on PR #316:
URL: https://github.com/apache/apisix-helm-chart/pull/316#issuecomment-1231155085
> @NMichas Do you think we need to release a new version of the Helm chart?
Sorry for the late reply, I was on holiday. Yes, a new release is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a diff in pull request #316: feat: Allow `fullnameOverride`s to work correctly
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #316:
URL: https://github.com/apache/apisix-helm-chart/pull/316#discussion_r932418764
##########
charts/apisix-ingress-controller/values.yaml:
##########
@@ -122,6 +122,8 @@ config:
enableGatewayAPI: false
# APISIX related configurations.
apisix:
+ # Enabling this value, overrides serviceName and serviceNamespace.
+ # serviceFullname: "apisix-admin"
Review Comment:
I think we should can set up an example here. e.g. `apisix-admin.apisix.svc.local`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #316: feat: Allow `fullnameOverride`s to work correctly
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged PR #316:
URL: https://github.com/apache/apisix-helm-chart/pull/316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #316: feat: Allow `fullnameOverride`s to work correctly
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #316:
URL: https://github.com/apache/apisix-helm-chart/pull/316#issuecomment-1232140936
@NMichas Don't worry.
If you have time, you can submit a PR that just needs to update its Helm chart version to release a new version. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #316: feat: Allow `fullnameOverride`s to work correctly
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #316:
URL: https://github.com/apache/apisix-helm-chart/pull/316#issuecomment-1195035648
Great!
let me take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] NMichas commented on a diff in pull request #316: feat: Allow `fullnameOverride`s to work correctly
Posted by GitBox <gi...@apache.org>.
NMichas commented on code in PR #316:
URL: https://github.com/apache/apisix-helm-chart/pull/316#discussion_r932881815
##########
charts/apisix-ingress-controller/values.yaml:
##########
@@ -122,6 +122,8 @@ config:
enableGatewayAPI: false
# APISIX related configurations.
apisix:
+ # Enabling this value, overrides serviceName and serviceNamespace.
+ # serviceFullname: "apisix-admin"
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #316: feat: Allow `fullnameOverride`s to work correctly
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #316:
URL: https://github.com/apache/apisix-helm-chart/pull/316#issuecomment-1213810151
@NMichas Do you think we need to release a new version of the Helm chart?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] NMichas commented on pull request #316: feat: Allow `fullnameOverride`s to work correctly
Posted by GitBox <gi...@apache.org>.
NMichas commented on PR #316:
URL: https://github.com/apache/apisix-helm-chart/pull/316#issuecomment-1235029021
@tao12345666333 sure, which versions should the update target? Current versions are:
APISIX:
- version: 0.11.1-rc1
- appVersion: 2.15.0
APISIX Ingress Controller:
- version: 0.10.0-rc1
- appVersion: 1.5.0-rc1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #316: feat: Allow `fullnameOverride`s to work correctly
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #316:
URL: https://github.com/apache/apisix-helm-chart/pull/316#issuecomment-1238750919
Sorry for delay. This update has been introduced to the latest version, no further action is required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org