You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "reschke (via GitHub)" <gi...@apache.org> on 2024/07/25 10:50:16 UTC
[PR] JCRVLT-762: Log/report UUIDs that cause import to switch to stashing … [jackrabbit-filevault]
reschke opened a new pull request, #342:
URL: https://github.com/apache/jackrabbit-filevault/pull/342
…and sysview import, also report on slow stashing progress
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCRVLT-762: Log/report node identifiers that cause import to switch to stashing … [jackrabbit-filevault]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on code in PR #342:
URL: https://github.com/apache/jackrabbit-filevault/pull/342#discussion_r1691578934
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewImporter.java:
##########
@@ -990,13 +991,20 @@ private void removeReferences(@NotNull Node node) throws ReferentialIntegrityExc
Optional<String> identifier = ni.getIdentifier();
// try to set uuid via sysview import if it differs from existing one
if (identifier.isPresent() && !node.getIdentifier().equals(identifier.get()) && !"rep:root".equals(ni.getPrimaryType().orElse(""))) {
+ long startTime = System.currentTimeMillis();
+ String previousIdentifier = node.getIdentifier();
+ log.info("Node stashing for {} starting, existing identifier: {}, new identifier: {}, import mode: {}",
Review Comment:
FWIW, there's also
---
for (String referencePath : removableReferencePaths) {
log.info("Remove reference towards {} at {}", node.getIdentifier(), referencePath);
session.removeItem(referencePath);
}
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCRVLT-762: Log/report node identifiers that cause import to switch to stashing … [jackrabbit-filevault]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #342:
URL: https://github.com/apache/jackrabbit-filevault/pull/342#discussion_r1691551312
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewImporter.java:
##########
@@ -990,13 +991,20 @@ private void removeReferences(@NotNull Node node) throws ReferentialIntegrityExc
Optional<String> identifier = ni.getIdentifier();
// try to set uuid via sysview import if it differs from existing one
if (identifier.isPresent() && !node.getIdentifier().equals(identifier.get()) && !"rep:root".equals(ni.getPrimaryType().orElse(""))) {
+ long startTime = System.currentTimeMillis();
+ String previousIdentifier = node.getIdentifier();
+ log.info("Node stashing for {} starting, existing identifier: {}, new identifier: {}, import mode: {}",
Review Comment:
With info level that is too verbose. Can we lower to debug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCRVLT-762: Log/report node identifiers that cause import to switch to stashing … [jackrabbit-filevault]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on code in PR #342:
URL: https://github.com/apache/jackrabbit-filevault/pull/342#discussion_r1691571399
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewImporter.java:
##########
@@ -990,13 +991,20 @@ private void removeReferences(@NotNull Node node) throws ReferentialIntegrityExc
Optional<String> identifier = ni.getIdentifier();
// try to set uuid via sysview import if it differs from existing one
if (identifier.isPresent() && !node.getIdentifier().equals(identifier.get()) && !"rep:root".equals(ni.getPrimaryType().orElse(""))) {
+ long startTime = System.currentTimeMillis();
+ String previousIdentifier = node.getIdentifier();
+ log.info("Node stashing for {} starting, existing identifier: {}, new identifier: {}, import mode: {}",
Review Comment:
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCRVLT-762: Log/report node identifiers that cause import to switch to stashing … [jackrabbit-filevault]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke merged PR #342:
URL: https://github.com/apache/jackrabbit-filevault/pull/342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org