You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/06 10:12:35 UTC
[GitHub] [superset] zhaoyongjie opened a new pull request #17947: refactor: import superset-ui/core from root of module
zhaoyongjie opened a new pull request #17947:
URL: https://github.com/apache/superset/pull/17947
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
TBD
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
CI
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged pull request #17947:
URL: https://github.com/apache/superset/pull/17947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r780002904
##########
File path: superset-frontend/packages/superset-ui-core/test/chart-composition/legend/WithLegend.test.tsx
##########
@@ -20,8 +20,8 @@
import React from 'react';
import { mount, shallow } from 'enzyme';
import { triggerResizeObserver } from 'resize-observer-polyfill';
-import { promiseTimeout } from '@superset-ui/core/src';
-import { WithLegend } from '@superset-ui/core/src/chart-composition';
+import { promiseTimeout } from '@superset-ui/core';
+import { WithLegend } from '../../../src/chart-composition';
Review comment:
`WithLegend` is a internal var in `@superset-ui/core`, in the other words `WithLegend` don't export from `@superset-ui/core`
there are lots of internal variables as "private var", we should use relative import expression to referring to for test it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r780002845
##########
File path: superset-frontend/package.json
##########
@@ -124,8 +124,10 @@
"d3-scale": "^2.1.2",
"dom-to-image": "^2.6.0",
"emotion-rgba": "0.0.9",
+ "fast-glob": "^3.2.7",
"fontsource-fira-code": "^3.0.5",
"fontsource-inter": "^3.0.5",
+ "fs-extra": "^10.0.0",
Review comment:
Ahh, I see. Should those be `devDependencies`, then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17947:
URL: https://github.com/apache/superset/pull/17947#issuecomment-1006489927
# [Codecov](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17947](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50a694d) into [master](https://codecov.io/gh/apache/superset/commit/79b6dc251e76b3e733f7b82d1ef171e9fb093c00?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (79b6dc2) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17947 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 1609 1609
Lines 64905 64905
Branches 6868 6868
=======================================
Hits 43537 43537
Misses 19502 19502
Partials 1866 1866
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.77% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [79b6dc2...50a694d](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r779999724
##########
File path: superset-frontend/package.json
##########
@@ -124,8 +124,10 @@
"d3-scale": "^2.1.2",
"dom-to-image": "^2.6.0",
"emotion-rgba": "0.0.9",
+ "fast-glob": "^3.2.7",
"fontsource-fira-code": "^3.0.5",
"fontsource-inter": "^3.0.5",
+ "fs-extra": "^10.0.0",
Review comment:
What are these for? They seem to be newer versions than what's used in plugins, so I'm not sure of the relevance to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17947:
URL: https://github.com/apache/superset/pull/17947#issuecomment-1006489927
# [Codecov](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17947](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (866ac7f) into [master](https://codecov.io/gh/apache/superset/commit/f75908b1dc075e5a0f697c828f2484051f72ecef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f75908b) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 866ac7f differs from pull request most recent head 8377b8a. Consider uploading reports for the commit 8377b8a to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17947 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 1609 1609
Lines 64905 64905
Branches 6868 6868
=======================================
Hits 43537 43537
Misses 19502 19502
Partials 1866 1866
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.77% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f75908b...8377b8a](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged pull request #17947:
URL: https://github.com/apache/superset/pull/17947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r780002904
##########
File path: superset-frontend/packages/superset-ui-core/test/chart-composition/legend/WithLegend.test.tsx
##########
@@ -20,8 +20,8 @@
import React from 'react';
import { mount, shallow } from 'enzyme';
import { triggerResizeObserver } from 'resize-observer-polyfill';
-import { promiseTimeout } from '@superset-ui/core/src';
-import { WithLegend } from '@superset-ui/core/src/chart-composition';
+import { promiseTimeout } from '@superset-ui/core';
+import { WithLegend } from '../../../src/chart-composition';
Review comment:
~~`WithLegend` is a internal var in `@superset-ui/core`, in the other words `WithLegend` don't export from `@superset-ui/core`~~
~~there are lots of internal variables as "private var", we should use relative import expression to referring to for test it.~~
You are right, I will change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r780002904
##########
File path: superset-frontend/packages/superset-ui-core/test/chart-composition/legend/WithLegend.test.tsx
##########
@@ -20,8 +20,8 @@
import React from 'react';
import { mount, shallow } from 'enzyme';
import { triggerResizeObserver } from 'resize-observer-polyfill';
-import { promiseTimeout } from '@superset-ui/core/src';
-import { WithLegend } from '@superset-ui/core/src/chart-composition';
+import { promiseTimeout } from '@superset-ui/core';
+import { WithLegend } from '../../../src/chart-composition';
Review comment:
`WithLegend` is a internal var in `@superset-ui/core`, in the other words `WithLegend` don't export from `@superset-ui/core`
there are lots of internal variables just uses as "private" var, we should use relative import expression to referring to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17947:
URL: https://github.com/apache/superset/pull/17947#issuecomment-1006489927
# [Codecov](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17947](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50a694d) into [master](https://codecov.io/gh/apache/superset/commit/79b6dc251e76b3e733f7b82d1ef171e9fb093c00?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (79b6dc2) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17947 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 1609 1609
Lines 64905 64905
Branches 6868 6868
=======================================
Hits 43537 43537
Misses 19502 19502
Partials 1866 1866
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.77% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [79b6dc2...50a694d](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r780002904
##########
File path: superset-frontend/packages/superset-ui-core/test/chart-composition/legend/WithLegend.test.tsx
##########
@@ -20,8 +20,8 @@
import React from 'react';
import { mount, shallow } from 'enzyme';
import { triggerResizeObserver } from 'resize-observer-polyfill';
-import { promiseTimeout } from '@superset-ui/core/src';
-import { WithLegend } from '@superset-ui/core/src/chart-composition';
+import { promiseTimeout } from '@superset-ui/core';
+import { WithLegend } from '../../../src/chart-composition';
Review comment:
`WithLegend` is a internal var in `@superset-ui/core`, in the other words `WithLegend` don't export from `@superset-ui/core`
there are lots of internal variables as "private var", we should use relative import expression to referring to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r780002904
##########
File path: superset-frontend/packages/superset-ui-core/test/chart-composition/legend/WithLegend.test.tsx
##########
@@ -20,8 +20,8 @@
import React from 'react';
import { mount, shallow } from 'enzyme';
import { triggerResizeObserver } from 'resize-observer-polyfill';
-import { promiseTimeout } from '@superset-ui/core/src';
-import { WithLegend } from '@superset-ui/core/src/chart-composition';
+import { promiseTimeout } from '@superset-ui/core';
+import { WithLegend } from '../../../src/chart-composition';
Review comment:
`WithLegend` is a internal var in `@superset-ui/core`, in the other words `WithLegend` don't export from `@superset-ui/core`
there are lots of internal var just uses as "private" var, we should use relative import expression to referring to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #17947: refactor: import module from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #17947:
URL: https://github.com/apache/superset/pull/17947#issuecomment-1006489927
# [Codecov](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17947](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (866ac7f) into [master](https://codecov.io/gh/apache/superset/commit/f75908b1dc075e5a0f697c828f2484051f72ecef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f75908b) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17947 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 1609 1609
Lines 64905 64905
Branches 6868 6868
=======================================
Hits 43537 43537
Misses 19502 19502
Partials 1866 1866
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.77% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f75908b...866ac7f](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r780001981
##########
File path: superset-frontend/package.json
##########
@@ -124,8 +124,10 @@
"d3-scale": "^2.1.2",
"dom-to-image": "^2.6.0",
"emotion-rgba": "0.0.9",
+ "fast-glob": "^3.2.7",
"fontsource-fira-code": "^3.0.5",
"fontsource-inter": "^3.0.5",
+ "fs-extra": "^10.0.0",
Review comment:
used in `superset-frontend/scripts/copyAsserts.js`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r780199715
##########
File path: superset-frontend/packages/superset-ui-core/test/chart/clients/ChartClient.test.ts
##########
@@ -24,17 +24,15 @@ import {
buildQueryContext,
QueryFormData,
configure as configureTranslation,
-} from '@superset-ui/core/src';
-
-import {
ChartClient,
getChartBuildQueryRegistry,
getChartMetadataRegistry,
ChartMetadata,
-} from '@superset-ui/core/src/chart';
-import { SliceIdAndOrFormData } from '@superset-ui/core/src/chart/clients/ChartClient';
+} from '@superset-ui/core';
+
import { LOGIN_GLOB } from '../fixtures/constants';
import { sankeyFormData } from '../fixtures/formData';
+import { SliceIdAndOrFormData } from '../../../src/chart/clients/ChartClient';
Review comment:
Since the packages are self-contained, is there a way to set something in each `package.json` or globally to make `packages/<package-name>` as the root for each package and avoid the `../.../...` imports?
##########
File path: superset-frontend/packages/superset-ui-core/test/chart/clients/ChartClient.test.ts
##########
@@ -24,17 +24,15 @@ import {
buildQueryContext,
QueryFormData,
configure as configureTranslation,
-} from '@superset-ui/core/src';
-
-import {
ChartClient,
getChartBuildQueryRegistry,
getChartMetadataRegistry,
ChartMetadata,
-} from '@superset-ui/core/src/chart';
-import { SliceIdAndOrFormData } from '@superset-ui/core/src/chart/clients/ChartClient';
+} from '@superset-ui/core';
+
import { LOGIN_GLOB } from '../fixtures/constants';
import { sankeyFormData } from '../fixtures/formData';
+import { SliceIdAndOrFormData } from '../../../src/chart/clients/ChartClient';
Review comment:
Since the packages are self-contained, is there a way to set something in each `package.json` or globally to make `packages/<package-name>` as the root for each package and avoid the `../../..` imports?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r780326093
##########
File path: superset-frontend/packages/superset-ui-core/test/chart/clients/ChartClient.test.ts
##########
@@ -24,17 +24,15 @@ import {
buildQueryContext,
QueryFormData,
configure as configureTranslation,
-} from '@superset-ui/core/src';
-
-import {
ChartClient,
getChartBuildQueryRegistry,
getChartMetadataRegistry,
ChartMetadata,
-} from '@superset-ui/core/src/chart';
-import { SliceIdAndOrFormData } from '@superset-ui/core/src/chart/clients/ChartClient';
+} from '@superset-ui/core';
+
import { LOGIN_GLOB } from '../fixtures/constants';
import { sankeyFormData } from '../fixtures/formData';
+import { SliceIdAndOrFormData } from '../../../src/chart/clients/ChartClient';
Review comment:
IMO, have to keep a simple and straightforward approach to link modules. We have to consider multiple runtime to alias these module
- Eslint
- Jest
- Webpack
This pattern only keep 1 principle "public variable name import from top level"
What do you think about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r780326093
##########
File path: superset-frontend/packages/superset-ui-core/test/chart/clients/ChartClient.test.ts
##########
@@ -24,17 +24,15 @@ import {
buildQueryContext,
QueryFormData,
configure as configureTranslation,
-} from '@superset-ui/core/src';
-
-import {
ChartClient,
getChartBuildQueryRegistry,
getChartMetadataRegistry,
ChartMetadata,
-} from '@superset-ui/core/src/chart';
-import { SliceIdAndOrFormData } from '@superset-ui/core/src/chart/clients/ChartClient';
+} from '@superset-ui/core';
+
import { LOGIN_GLOB } from '../fixtures/constants';
import { sankeyFormData } from '../fixtures/formData';
+import { SliceIdAndOrFormData } from '../../../src/chart/clients/ChartClient';
Review comment:
IMO, have to keep a simple and straightforward approach to link modules. We have to consider multiple runtime to alias these module
- Eslint
- Jest
- Webpack
This pattern only keep 1 principle "public variable name import from top level"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #17947:
URL: https://github.com/apache/superset/pull/17947#issuecomment-1007316573
Love it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r780006082
##########
File path: superset-frontend/package.json
##########
@@ -124,8 +124,10 @@
"d3-scale": "^2.1.2",
"dom-to-image": "^2.6.0",
"emotion-rgba": "0.0.9",
+ "fast-glob": "^3.2.7",
"fontsource-fira-code": "^3.0.5",
"fontsource-inter": "^3.0.5",
+ "fs-extra": "^10.0.0",
Review comment:
`eslint` suggest staying in dependecies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r779998412
##########
File path: superset-frontend/packages/superset-ui-core/test/chart-composition/legend/WithLegend.test.tsx
##########
@@ -20,8 +20,8 @@
import React from 'react';
import { mount, shallow } from 'enzyme';
import { triggerResizeObserver } from 'resize-observer-polyfill';
-import { promiseTimeout } from '@superset-ui/core/src';
-import { WithLegend } from '@superset-ui/core/src/chart-composition';
+import { promiseTimeout } from '@superset-ui/core';
+import { WithLegend } from '../../../src/chart-composition';
Review comment:
Think it's worth the trouble to `export` this from `@superset-ui/core` so that we can just do:
`import { promiseTimeout, WithLegend } from '@superset-ui/core';`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17947:
URL: https://github.com/apache/superset/pull/17947#issuecomment-1006489927
# [Codecov](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17947](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8377b8a) into [master](https://codecov.io/gh/apache/superset/commit/f75908b1dc075e5a0f697c828f2484051f72ecef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f75908b) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 8377b8a differs from pull request most recent head 50a694d. Consider uploading reports for the commit 50a694d to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17947 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 1609 1609
Lines 64905 64905
Branches 6868 6868
=======================================
Hits 43537 43537
Misses 19502 19502
Partials 1866 1866
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.77% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [79b6dc2...50a694d](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r780326093
##########
File path: superset-frontend/packages/superset-ui-core/test/chart/clients/ChartClient.test.ts
##########
@@ -24,17 +24,15 @@ import {
buildQueryContext,
QueryFormData,
configure as configureTranslation,
-} from '@superset-ui/core/src';
-
-import {
ChartClient,
getChartBuildQueryRegistry,
getChartMetadataRegistry,
ChartMetadata,
-} from '@superset-ui/core/src/chart';
-import { SliceIdAndOrFormData } from '@superset-ui/core/src/chart/clients/ChartClient';
+} from '@superset-ui/core';
+
import { LOGIN_GLOB } from '../fixtures/constants';
import { sankeyFormData } from '../fixtures/formData';
+import { SliceIdAndOrFormData } from '../../../src/chart/clients/ChartClient';
Review comment:
IMO, have to keep a simple and straightforward approach to link modules. We have to consider multiple runtime to alias these module
- Eslint
- Jest
- Webpack
This pattern only keep 1 principle "public variable name import from top level"
##########
File path: superset-frontend/packages/superset-ui-core/test/chart/clients/ChartClient.test.ts
##########
@@ -24,17 +24,15 @@ import {
buildQueryContext,
QueryFormData,
configure as configureTranslation,
-} from '@superset-ui/core/src';
-
-import {
ChartClient,
getChartBuildQueryRegistry,
getChartMetadataRegistry,
ChartMetadata,
-} from '@superset-ui/core/src/chart';
-import { SliceIdAndOrFormData } from '@superset-ui/core/src/chart/clients/ChartClient';
+} from '@superset-ui/core';
+
import { LOGIN_GLOB } from '../fixtures/constants';
import { sankeyFormData } from '../fixtures/formData';
+import { SliceIdAndOrFormData } from '../../../src/chart/clients/ChartClient';
Review comment:
IMO, have to keep a simple and straightforward approach to link modules. We have to consider multiple runtime to alias these module
- Eslint
- Jest
- Webpack
This pattern only keep 1 principle "public variable name import from top level"
What do you think about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r780002904
##########
File path: superset-frontend/packages/superset-ui-core/test/chart-composition/legend/WithLegend.test.tsx
##########
@@ -20,8 +20,8 @@
import React from 'react';
import { mount, shallow } from 'enzyme';
import { triggerResizeObserver } from 'resize-observer-polyfill';
-import { promiseTimeout } from '@superset-ui/core/src';
-import { WithLegend } from '@superset-ui/core/src/chart-composition';
+import { promiseTimeout } from '@superset-ui/core';
+import { WithLegend } from '../../../src/chart-composition';
Review comment:
`WithLegend` is a internal var in `@superset-ui/core`, in the other words `WithLegend` don't export from `@superset-ui/core`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r780006082
##########
File path: superset-frontend/package.json
##########
@@ -124,8 +124,10 @@
"d3-scale": "^2.1.2",
"dom-to-image": "^2.6.0",
"emotion-rgba": "0.0.9",
+ "fast-glob": "^3.2.7",
"fontsource-fira-code": "^3.0.5",
"fontsource-inter": "^3.0.5",
+ "fs-extra": "^10.0.0",
Review comment:
`eslint` suggest staying in dependecies,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #17947:
URL: https://github.com/apache/superset/pull/17947#issuecomment-1007316573
Love it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r780199715
##########
File path: superset-frontend/packages/superset-ui-core/test/chart/clients/ChartClient.test.ts
##########
@@ -24,17 +24,15 @@ import {
buildQueryContext,
QueryFormData,
configure as configureTranslation,
-} from '@superset-ui/core/src';
-
-import {
ChartClient,
getChartBuildQueryRegistry,
getChartMetadataRegistry,
ChartMetadata,
-} from '@superset-ui/core/src/chart';
-import { SliceIdAndOrFormData } from '@superset-ui/core/src/chart/clients/ChartClient';
+} from '@superset-ui/core';
+
import { LOGIN_GLOB } from '../fixtures/constants';
import { sankeyFormData } from '../fixtures/formData';
+import { SliceIdAndOrFormData } from '../../../src/chart/clients/ChartClient';
Review comment:
Since the packages are self-contained, is there a way to set something in each `package.json` or globally to make `packages/<package-name>` as the root for each package and avoid the `../../..` imports?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r780199715
##########
File path: superset-frontend/packages/superset-ui-core/test/chart/clients/ChartClient.test.ts
##########
@@ -24,17 +24,15 @@ import {
buildQueryContext,
QueryFormData,
configure as configureTranslation,
-} from '@superset-ui/core/src';
-
-import {
ChartClient,
getChartBuildQueryRegistry,
getChartMetadataRegistry,
ChartMetadata,
-} from '@superset-ui/core/src/chart';
-import { SliceIdAndOrFormData } from '@superset-ui/core/src/chart/clients/ChartClient';
+} from '@superset-ui/core';
+
import { LOGIN_GLOB } from '../fixtures/constants';
import { sankeyFormData } from '../fixtures/formData';
+import { SliceIdAndOrFormData } from '../../../src/chart/clients/ChartClient';
Review comment:
Since the packages are self-contained, is there a way to set something in each `package.json` or globally to make `packages/<package-name>` as the root for each package and avoid the `../.../...` imports?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17947: refactor: import value name from root of superset-ui/core
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17947:
URL: https://github.com/apache/superset/pull/17947#issuecomment-1006489927
# [Codecov](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17947](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8377b8a) into [master](https://codecov.io/gh/apache/superset/commit/f75908b1dc075e5a0f697c828f2484051f72ecef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f75908b) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17947 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 1609 1609
Lines 64905 64905
Branches 6868 6868
=======================================
Hits 43537 43537
Misses 19502 19502
Partials 1866 1866
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.77% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f75908b...8377b8a](https://codecov.io/gh/apache/superset/pull/17947?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org