[GitHub] [gobblin] arjun4084346 commented on a change in pull request #3459: [GOBBLIN-1602] Change hive table location and partition check to validate using FS r…

[GitBox <gi...@apache.org>]

arjun4084346 commented on a change in pull request #3459:
URL: https://github.com/apache/gobblin/pull/3459#discussion_r801396039



##########
File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/hive/HivePartitionFileSet.java
##########
@@ -99,7 +99,7 @@ public HivePartitionFileSet(HiveCopyEntityHelper hiveCopyEntityHelper, Partition
               hiveCopyEntityHelper.getExistingEntityPolicy() != HiveCopyEntityHelper.ExistingEntityPolicy.REPLACE_TABLE_AND_PARTITIONS) {
             log.error("Source and target partitions are not compatible. Aborting copy of partition " + this.partition,
                 ioe);
-            return Lists.newArrayList();
+            throw ioe;

Review comment:
       Does the override policy already exist @Will-Lo ?
   If there are 10 partitioned tables to be copied and the 3rd table has incompatible target location, will 2 tables be copied or 9 or none?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org