You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/01/03 14:16:12 UTC

Review Request 55140: Added tests for parsing OCI image spec.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55140/
-----------------------------------------------------------

Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-6681
    https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
-------

Added tests for parsing OCI image spec.


Diffs
-----

  src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 
  src/tests/CMakeLists.txt b034f1b88337b003d01450eadd262b9bc763545c 
  src/tests/containerizer/oci_spec_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/55140/diff/


Testing
-------


Thanks,

Qian Zhang

Re: Review Request 55140: Added tests for parsing OCI image spec.

Posted by Qian Zhang <zh...@gmail.com>.

> On Feb. 5, 2017, 12:09 p.m., Jie Yu wrote:
> > src/tests/containerizer/oci_spec_tests.cpp, line 39
> > <https://reviews.apache.org/r/55140/diff/3/?file=1621007#file1621007line39>
> >
> >     Why you need a JSON here? Can that just be a string?
> >     
> >     Ditto elsewhere in this file.

Thanks for catching this! I followed the same way of the tests in `appc_spec_test.cpp`, so I think we'd better to fix it in that file, right?


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55140/#review164264
-----------------------------------------------------------


On Feb. 1, 2017, 9:14 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55140/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2017, 9:14 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6681
>     https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for parsing OCI image spec.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430 
>   src/tests/CMakeLists.txt 44b74ee591b14d7d69bc0c03c26167b33eaa789c 
>   src/tests/containerizer/oci_spec_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55140/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 55140: Added tests for parsing OCI image spec.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55140/#review164264
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/oci_spec_tests.cpp (line 28)
<https://reviews.apache.org/r/55140/#comment235930>

    Let's move this above 'using std::string'



src/tests/containerizer/oci_spec_tests.cpp (line 39)
<https://reviews.apache.org/r/55140/#comment235932>

    Why you need a JSON here? Can that just be a string?
    
    Ditto elsewhere in this file.


- Jie Yu


On Feb. 1, 2017, 1:14 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55140/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2017, 1:14 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6681
>     https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for parsing OCI image spec.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430 
>   src/tests/CMakeLists.txt 44b74ee591b14d7d69bc0c03c26167b33eaa789c 
>   src/tests/containerizer/oci_spec_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55140/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 55140: Added tests for parsing OCI image spec.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55140/
-----------------------------------------------------------

(Updated Feb. 7, 2017, 4:43 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-6681
    https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
-------

Added tests for parsing OCI image spec.


Diffs
-----

  src/Makefile.am 78d55d86b1e1238beda3163d3240c85609ea982d 
  src/tests/CMakeLists.txt c12a9f7f7be0ed87a5dab8f78590be5f65517b6c 
  src/tests/containerizer/oci_spec_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/55140/diff/


Testing (updated)
-------

make check GTEST_FILTER="OCISpecTest.*"


Thanks,

Qian Zhang

Re: Review Request 55140: Added tests for parsing OCI image spec.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55140/
-----------------------------------------------------------

(Updated Feb. 7, 2017, 4:42 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
-------

Addressed Jie's comments.


Bugs: MESOS-6681
    https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
-------

Added tests for parsing OCI image spec.


Diffs (updated)
-----

  src/Makefile.am 78d55d86b1e1238beda3163d3240c85609ea982d 
  src/tests/CMakeLists.txt c12a9f7f7be0ed87a5dab8f78590be5f65517b6c 
  src/tests/containerizer/oci_spec_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/55140/diff/


Testing
-------


Thanks,

Qian Zhang

Re: Review Request 55140: Added tests for parsing OCI image spec.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55140/
-----------------------------------------------------------

(Updated Feb. 1, 2017, 9:14 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
-------

Rebased.


Bugs: MESOS-6681
    https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
-------

Added tests for parsing OCI image spec.


Diffs (updated)
-----

  src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430 
  src/tests/CMakeLists.txt 44b74ee591b14d7d69bc0c03c26167b33eaa789c 
  src/tests/containerizer/oci_spec_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/55140/diff/


Testing
-------


Thanks,

Qian Zhang

Re: Review Request 55140: Added tests for parsing OCI image spec.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55140/
-----------------------------------------------------------

(Updated Jan. 9, 2017, 3:27 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
-------

Rebased


Bugs: MESOS-6681
    https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
-------

Added tests for parsing OCI image spec.


Diffs (updated)
-----

  src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 
  src/tests/CMakeLists.txt b034f1b88337b003d01450eadd262b9bc763545c 
  src/tests/containerizer/oci_spec_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/55140/diff/


Testing
-------


Thanks,

Qian Zhang