You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by dragon512 <gi...@git.apache.org> on 2016/05/31 15:41:51 UTC
[GitHub] trafficserver pull request: Update configure.ac
GitHub user dragon512 opened a pull request:
https://github.com/apache/trafficserver/pull/679
Update configure.ac
Change "aux" directory to a value that does not upset systems that use this value as a device name for legacy purposes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dragon512/trafficserver dragon512-patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/679.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #679
----
commit 590e77860ff3b9b755a00265ecd5de0f6357fc1b
Author: dragon512 <dr...@live.com>
Date: 2016-05-31T15:40:06Z
Update configure.ac
Change "aux" directory to a value that does not upset systems that use this value as a device name for legacy purposes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Update configure.ac
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/679
I can live with ts_aux :)
> On May 31, 2016, at 11:16 AM, Leif Hedstrom <no...@github.com> wrote:
>
> Meh, ts_aux seemed to be a more recognizable name to me, why are we convoluting this just because one person hates underscores?
>
> \u2014
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #679: Update configure.ac
Posted by dragon512 <gi...@git.apache.org>.
Github user dragon512 commented on the issue:
https://github.com/apache/trafficserver/pull/679
The only concern i would have with .aux is that it hides files, and if you don't know that you should look for them, it can be hard to find them when trying to solve some problem or understand what is going on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #679: Update configure.ac
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/679
After some discussion with Jason and looking at other parts of the build tree, I went with "_aux" because that's the convention the doc subtree uses. Lacking any better reason to pick one name over the other, I sided with consistency.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Update configure.ac
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/679
Meh, ts_aux seemed to be a more recognizable name to me, why are we convoluting this just because one person hates underscores?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #679: Update configure.ac
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/679
Let's update ``.gitignore``, then merge this once @zwoop gives his +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Update configure.ac
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/679
I'll squash it when I commit it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Update configure.ac
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/679
``build/.aux`` is another possibility, though as I mentioned above, I'm OK with ``ts_aux`` too. Please also change it in ``.gitignore``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Update configure.ac
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/679#discussion_r65211314
--- Diff: configure.ac ---
@@ -37,7 +37,7 @@ m4_define([TS_VERSION_N],[7000000])
AC_INIT([Apache Traffic Server], TS_VERSION_S(), [dev@trafficserver.apache.org], [trafficserver],[http://trafficserver.apache.org])
AC_PREREQ([2.59])
-AC_CONFIG_AUX_DIR([build/aux])
+AC_CONFIG_AUX_DIR([build/ts_aux])
--- End diff --
``support`` might scan a bit nicer?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Update configure.ac
Posted by dragon512 <gi...@git.apache.org>.
Github user dragon512 commented on the pull request:
https://github.com/apache/trafficserver/pull/679
Honestly I would use _aux myself. Allen said somebody hates _ so i made it ts_aux. honestly it does not matter it just cannot be prn, aux, or con
It is useful for "generated" items to be in directories that are easy to find and delete outside some tool being used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #679: Update configure.ac
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/679
I'm fine with .aux, _aux, ts_aux, or anything aux :). +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Update configure.ac
Posted by dragon512 <gi...@git.apache.org>.
Github user dragon512 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/679#discussion_r65234405
--- Diff: configure.ac ---
@@ -37,7 +37,7 @@ m4_define([TS_VERSION_N],[7000000])
AC_INIT([Apache Traffic Server], TS_VERSION_S(), [dev@trafficserver.apache.org], [trafficserver],[http://trafficserver.apache.org])
AC_PREREQ([2.59])
-AC_CONFIG_AUX_DIR([build/aux])
+AC_CONFIG_AUX_DIR([build/ts_aux])
--- End diff --
Done...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Update configure.ac
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/679
At least squash this down to one commit, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #679: Update configure.ac
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/679
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---