You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/12/18 13:38:28 UTC
[GitHub] [cordova-coho] NiklasMerz opened a new pull request #287: docs: link to checklist in voring document that is linked in every email
NiklasMerz opened a new pull request #287:
URL: https://github.com/apache/cordova-coho/pull/287
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
coho
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
We link to the voting guidelines in every vote email. This PR adds the new checklist as a TLDR at the top to make it more accessible and encourage votes.
### Description
<!-- Describe your changes in detail -->
Just a link in docs.
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-coho] codecov-commenter commented on pull request #287: docs: link to checklist in voring document that is linked in every email
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #287:
URL: https://github.com/apache/cordova-coho/pull/287#issuecomment-997203824
# [Codecov](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#287](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37d7bd5) into [master](https://codecov.io/gh/apache/cordova-coho/commit/277dcc7b6c74bea45471c230fbc70c5aa721e0bf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (277dcc7) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #287 +/- ##
=======================================
Coverage 58.73% 58.73%
=======================================
Files 8 8
Lines 492 492
=======================================
Hits 289 289
Misses 203 203
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [277dcc7...37d7bd5](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-coho] breautek commented on a change in pull request #287: docs: link to checklist in voting document that is linked in every email
Posted by GitBox <gi...@apache.org>.
breautek commented on a change in pull request #287:
URL: https://github.com/apache/cordova-coho/pull/287#discussion_r801863930
##########
File path: docs/release-voting.md
##########
@@ -21,6 +21,8 @@
# Release Voting Guidelines
+> This document describes what Apache requires you to do for a vote. Please make sure you understand this first. You can refert to the [shorter checklist](./vote-checklist.md) every time you vote.
Review comment:
typo
##########
File path: docs/release-voting.md
##########
@@ -21,6 +21,8 @@
# Release Voting Guidelines
+> This document describes what Apache requires you to do for a vote. Please make sure you understand this first. You can refert to the [shorter checklist](./vote-checklist.md) every time you vote.
Review comment:
```suggestion
> This document describes what Apache requires you to do for a vote. Please make sure you understand this first. You can refer to the [shorter checklist](./vote-checklist.md) every time you vote.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-coho] codecov-commenter edited a comment on pull request #287: docs: link to checklist in voring document that is linked in every email
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #287:
URL: https://github.com/apache/cordova-coho/pull/287#issuecomment-997203824
# [Codecov](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#287](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37d7bd5) into [master](https://codecov.io/gh/apache/cordova-coho/commit/277dcc7b6c74bea45471c230fbc70c5aa721e0bf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (277dcc7) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #287 +/- ##
=======================================
Coverage 58.73% 58.73%
=======================================
Files 8 8
Lines 492 492
=======================================
Hits 289 289
Misses 203 203
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [277dcc7...37d7bd5](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-coho] codecov-commenter edited a comment on pull request #287: docs: link to checklist in voting document that is linked in every email
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #287:
URL: https://github.com/apache/cordova-coho/pull/287#issuecomment-997203824
# [Codecov](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#287](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (23d77c6) into [master](https://codecov.io/gh/apache/cordova-coho/commit/277dcc7b6c74bea45471c230fbc70c5aa721e0bf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (277dcc7) will **decrease** coverage by `1.82%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #287 +/- ##
==========================================
- Coverage 58.73% 56.91% -1.83%
==========================================
Files 8 8
Lines 492 492
==========================================
- Hits 289 280 -9
- Misses 203 212 +9
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/superspawn.js](https://codecov.io/gh/apache/cordova-coho/pull/287/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3N1cGVyc3Bhd24uanM=) | `50.00% <0.00%> (-11.85%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [277dcc7...23d77c6](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-coho] codecov-commenter edited a comment on pull request #287: docs: link to checklist in voting document that is linked in every email
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #287:
URL: https://github.com/apache/cordova-coho/pull/287#issuecomment-997203824
# [Codecov](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#287](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (23d77c6) into [master](https://codecov.io/gh/apache/cordova-coho/commit/277dcc7b6c74bea45471c230fbc70c5aa721e0bf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (277dcc7) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #287 +/- ##
=======================================
Coverage 58.73% 58.73%
=======================================
Files 8 8
Lines 492 492
=======================================
Hits 289 289
Misses 203 203
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [277dcc7...23d77c6](https://codecov.io/gh/apache/cordova-coho/pull/287?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org