You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/04/01 07:38:09 UTC

[GitHub] [jackrabbit-oak] thomasmueller commented on pull request #534: OAK-9743 oak-run indexing doesn't support facets

thomasmueller commented on pull request #534:
URL: https://github.com/apache/jackrabbit-oak/pull/534#issuecomment-1085538014


   > Regarding the test, I think we can possibly add a test here https://github.com/apache/jackrabbit-oak/blob/trunk/oak-run/src/test/java/org/apache/jackrabbit/oak/index/DocumentStoreIndexerIT.java , where we should be able to reindex using oak-run and then test a facet query in assertion for correct results. I am ok if we want to take this as a separate task too, since this change is important to go in.
   > 
   > But if it's easier to write the test case - then would appreciate if we can do it as part of this PR only.
   
   I fully agree! I'll create an issue for that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org