[GitHub] [spark] warrenzhu25 commented on a diff in pull request #41071: [SPARK-43391][CORE] Idle connection should be kept when closeIdleConnection is disabled

["warrenzhu25 (via GitHub)" <gi...@apache.org>]

warrenzhu25 commented on code in PR #41071:
URL: https://github.com/apache/spark/pull/41071#discussion_r1186767910


##########
common/network-common/src/test/java/org/apache/spark/network/RequestTimeoutIntegrationSuite.java:
##########
@@ -110,7 +110,7 @@ public StreamManager getStreamManager() {
       }
     };
 
-    context = new TransportContext(conf, handler);
+    context = new TransportContext(conf, handler, true);

Review Comment:
   Spark has both usage pattern with the later has `closeIdleConnection` as `false`.  But the previous behavior ignored `closeIdleConnection`, so I think it's safe to update this test to match the correct behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org