You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2023/08/24 09:49:14 UTC
[GitHub] [spark] yaooqinn opened a new pull request, #42654: [SPARK-44863][UI][3.5] Add a button to download thread dump as a txt in Spark UI
yaooqinn opened a new pull request, #42654:
URL: https://github.com/apache/spark/pull/42654
### What changes were proposed in this pull request?
This PR added a button to download thread dump as a txt w.r.t. jstack formatting
### Why are the changes needed?
The formatting of raw jstack can be relatively easy to read and analyze using various thread tools.
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
#### Raw Dump File
[driver.txt](https://github.com/apache/spark/files/12388302/driver.txt)
#### Reporting by external tools
https://fastthread.io/my-thread-report.jsp?p=c2hhcmVkLzIwMjMvMDgvMjAvZHJpdmVyLnR4dC0tMTMtNTMtMjI=&
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42654: [SPARK-44863][UI][3.5] Add a button to download thread dump as a txt in Spark UI
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42654:
URL: https://github.com/apache/spark/pull/42654#issuecomment-1692153231
In addition, this umbrella itself is for Apache Spark 4.0.0, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42654: [SPARK-44863][UI][3.5] Add a button to download thread dump as a txt in Spark UI
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42654:
URL: https://github.com/apache/spark/pull/42654#issuecomment-1692665222
Thank you for the decision, @yaooqinn and @zhengruifeng .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42654: [SPARK-44863][UI][3.5] Add a button to download thread dump as a txt in Spark UI
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42654:
URL: https://github.com/apache/spark/pull/42654#issuecomment-1692610167
@dongjoon-hyun yes, thanks for the reminder.
@yaooqinn let's keep this feature only in master, sorry for asking for merging to 3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #42654: [SPARK-44863][UI][3.5] Add a button to download thread dump as a txt in Spark UI
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #42654:
URL: https://github.com/apache/spark/pull/42654#issuecomment-1692647452
It's okay @zhengruifeng. And thank you, @dongjoon-hyun, for the clarification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn closed pull request #42654: [SPARK-44863][UI][3.5] Add a button to download thread dump as a txt in Spark UI
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #42654: [SPARK-44863][UI][3.5] Add a button to download thread dump as a txt in Spark UI
URL: https://github.com/apache/spark/pull/42654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org