[jira] [Commented] (OPENNLP-1020) MockInputStreamFactory.createInputStream should create a new InputStream

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968898#comment-15968898 ] 

ASF GitHub Bot commented on OPENNLP-1020:
-----------------------------------------

GitHub user kojisekig opened a pull request:

    https://github.com/apache/opennlp/pull/156

    OPENNLP-1020: MockInputStreamFactory.createInputStream should create a new InputStream

    Thank you for contributing to Apache OpenNLP.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [Y] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [Y] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [Y] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [Y] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [Y] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
    - [Y] Have you written or updated unit tests to verify your changes?
    - [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [N/A] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
    - [N/A] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
    
    ### For documentation related changes:
    - [N/A] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kojisekig/opennlp fix-MockInputStreamFactory

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/opennlp/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #156
    
----
commit 6352843d158fffd74315388800bc09ad66e48304
Author: koji <ko...@rondhuit.com>
Date:   2017-04-14T11:02:22Z

    OPENNLP-1020: MockInputStreamFactory.createInputStream should create a new InputStream

----


> MockInputStreamFactory.createInputStream should create a new InputStream
> ------------------------------------------------------------------------
>
>                 Key: OPENNLP-1020
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1020
>             Project: OpenNLP
>          Issue Type: Bug
>          Components: Build, Packaging and Test
>            Reporter: Koji Sekiguchi
>            Priority: Minor
>              Labels: test
>
> Working on OPENNLP-1018, if I added a test for reset() of PlainTextByLineStream to the existing PlainTextByLineStreamTest, it doesn't work because it uses MockInputStreamFactory and call MockInputStreamFactory.createInputStream() in reset() but MockInputStreamFactory.createInputStream() doesn't create a new input stream but just returns input stream which it holds instead.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)