[jira] [Commented] (STORM-933) NullPointerException during KafkaSpout deactivation

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651205#comment-14651205 ] 

ASF GitHub Bot commented on STORM-933:
--------------------------------------

Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/660#issuecomment-127075818
  
    We can add null check from KafkaSpout.commit() to save tiny memory (by lazy allocation), but it is really tiny so I think current approach is acceptable.
    +1.


> NullPointerException during KafkaSpout deactivation
> ---------------------------------------------------
>
>                 Key: STORM-933
>                 URL: https://issues.apache.org/jira/browse/STORM-933
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-kafka
>    Affects Versions: 0.9.5
>            Reporter: Patricio Echague
>            Assignee: caofangkun
>
> We are seeing this during a topology shutdown
> 2015-07-09 19:51:48-0700 b.s.util [ERROR] Async loop died!
> java.lang.NullPointerException: null
>         at storm.kafka.KafkaSpout.commit(KafkaSpout.java:190) ~[stormjar.jar:na]
>         at storm.kafka.KafkaSpout.deactivate(KafkaSpout.java:180) ~[stormjar.jar:na]
>         at com.relateiq.storm.JMXActivatableSpout.deactivate(JMXActivatableSpout.java:75) ~[stormjar.jar:na]
>         at backtype.storm.daemon.executor$fn__6579$fn__6594$fn__6623.invoke(executor.clj:570) ~[storm-core-0.9.5.jar:0.9.5]
>         at backtype.storm.util$async_loop$fn__459.invoke(util.clj:463) ~[storm-core-0.9.5.jar:0.9.5]
>         at clojure.lang.AFn.run(AFn.java:24) [clojure-1.5.1.jar:na]
>         at java.lang.Thread.run(Thread.java:745) [na:1.8.0_31]
> 2015-07-09 19:51:48-0700 b.s.d.executor [ERROR]
> Thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)