[GitHub] [incubator-superset] rusackas commented on pull request #12125: fix: Fix chart save and go button

[GitBox <gi...@apache.org>]

rusackas commented on pull request #12125:
URL: https://github.com/apache/incubator-superset/pull/12125#issuecomment-748324531


   > LGTM. Could you confirm whether this added `dashboardId` will persist in chart formData when you save? (It probably shouldn't. But shouldn't be a problem if it does.)
   
   Thanks @ktmud - this is a good catch. Agree that it's non-blocking, so I hit the big green button, but @michael-s-molina if you could confirm and file another PR to fix if it's persisting that, it would be appreciated! And thank you for this great UX improvement!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org