[GitHub] [trafficcontrol] ChrisHines commented on a change in pull request #4106: Add top level golang linter and golang unit test

[GitBox <gi...@apache.org>]

ChrisHines commented on a change in pull request #4106: Add top level golang linter and golang unit test
URL: https://github.com/apache/trafficcontrol/pull/4106#discussion_r344832440
 
 

 ##########
 File path: .golangci.yml
 ##########
 @@ -0,0 +1,43 @@
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+run:
+  concurrency: 4
+  timeout: 5m
+  issues-exit-code: 0 # TODO: once all enabled linters are satisfied  
+  tests: false
+  skip-dirs:
+    (^|/).*traffic_router_golang.*($|/)
+  skip-dirs-use-default: true
+
+  output:
+  # colored-line-number|line-number|json|tab|checkstyle|code-climate, default is "colored-line-number"
+    format: colored-line-number
+    print-issued-lines: true
+    print-linter-name: true
+
+linters:
+  disable-all: true
+  enable:
+    - govet
+    - errcheck
+    - unused
+    - structcheck
+    - varcheck
+    - deadcode
+    - typecheck
+    - golint
+    - gofmt
 
 Review comment:
   I'm not sure this is the best list of linters. In particular I would strongly encourage the use of staticcheck and take away unused (it was subsumed into staticcheck a while ago)? Also I suspect staticcheck does a better job at the checks that varcheck, deadcode, typecheck are trying to do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services