You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "GanfengTan (via GitHub)" <gi...@apache.org> on 2023/07/21 02:48:02 UTC

[GitHub] [inlong] GanfengTan commented on a diff in pull request #8475: [INLONG-8445][Sort] Support running tests on both Flink 1.13 and Flink 1.15

GanfengTan commented on code in PR #8475:
URL: https://github.com/apache/inlong/pull/8475#discussion_r1270173702


##########
inlong-sort/sort-dist/pom.xml:
##########
@@ -126,6 +126,10 @@
             <activation>
                 <activeByDefault>true</activeByDefault>
             </activation>
+            <properties>
+                <flink.version>1.13.5</flink.version>
+                <scala.binary.version>2.11</scala.binary.version>
+            </properties>

Review Comment:
   There are already global variables in the root pom.



##########
inlong-sort/sort-end-to-end-tests/sort-end-to-end-tests-v1.13/src/test/resources/log4j2-test.properties:
##########
@@ -57,10 +57,10 @@ logger.tm.name=org.apache.flink.runtime.taskexecutor.TaskExecutor
 logger.tm.additivity=false
 
 logger.mysql=INFO, mysql
-logger.mysql.name=org.apache.inlong.sort.tests.utils.MySqlContainer
+logger.mysql.name=org.apache.inlong.sort.org.apache.inlong.sort.tests.utils.MySqlContainer

Review Comment:
   The writing in this place is not very appropriate, please modify it.



##########
inlong-sort/sort-dist/pom.xml:
##########
@@ -145,19 +149,25 @@
                 <dependency>
                     <groupId>org.apache.flink</groupId>
                     <artifactId>flink-csv</artifactId>
+                    <version>${flink.version}</version>
                 </dependency>
                 <dependency>
                     <groupId>org.apache.flink</groupId>
                     <artifactId>flink-json</artifactId>
+                    <version>${flink.version}</version>
                 </dependency>
                 <dependency>
                     <groupId>org.apache.flink</groupId>
                     <artifactId>flink-sql-avro</artifactId>
+                    <version>${flink.version}</version>
                 </dependency>
             </dependencies>
         </profile>
         <profile>
             <id>v1.15</id>
+            <properties>
+                <flink.version>1.15.4</flink.version>
+            </properties>

Review Comment:
   ditto



##########
inlong-sort/sort-end-to-end-tests/sort-end-to-end-tests-v1.13/src/test/resources/log4j2-test.properties:
##########
@@ -57,10 +57,10 @@ logger.tm.name=org.apache.flink.runtime.taskexecutor.TaskExecutor
 logger.tm.additivity=false
 
 logger.mysql=INFO, mysql
-logger.mysql.name=org.apache.inlong.sort.tests.utils.MySqlContainer
+logger.mysql.name=org.apache.inlong.sort.org.apache.inlong.sort.tests.utils.MySqlContainer
 logger.mysql.additivity=false
 
 logger.kafka=INFO, kafkaserver
-logger.kafka.name=org.apache.inlong.sort.tests.KafkaE2ECase
+logger.kafka.name=org.apache.inlong.sort.org.apache.inlong.sort.tests.KafkaE2ECase
 logger.kafka.additivity=false

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org