You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@groovy.apache.org by Yazad Khambata <ya...@gmail.com> on 2017/06/19 02:37:48 UTC
Re: Some trivial tickets
Hi Paul,
Just wanted to check if you are good with the analysis provided for,
GROOVY-5227 - AbstractHttpServlet should extend GenericServlet
directly instead of HttpServlet
Please suggest if you'd like to fix or close based on the analysis and
suggestions provided in the comments.
Also as the next ticket I was wondering if I could take up,
GROOVY-6485 - Replace usage of String#toUpperCase() with
String#toUpperCase(Locale.ENGLISH)
Thank you.
Regards,
Yazad Khambata
On Thu, May 4, 2017 at 8:56 AM, Yazad Khambata <ya...@gmail.com> wrote:
> Forwarded broken chain earlier.
>
> ---------- Forwarded message ---------
> From: Yazad Khambata <ya...@gmail.com>
> Date: Thu, May 4, 2017 at 6:00 AM
> Subject: Re: Some trivial tickets
> To: <pa...@asert.com.au>
>
>
> Hi Paul,
>
> Awesome, I will provide my analysis on GROOVY-5227 soon. Thank you!
>
> Regards,
>
> On Thu, May 4, 2017 at 2:06 AM Paul King <pa...@asert.com.au> wrote:
>>
>>
>> Hi Yazad,
>>
>> I wouldn't bother with GROOVY-7388. I can imagine some scenarios where
>> ambiguous messages might occur but they wouldn't involve normal usage of
>> those methods. I have closed for now. If the OP provides more information we
>> can pursue that one.
>>
>> GROOVY-5227 seems worthy of investigation. An analysis would be great.
>>
>> Hopefully some more tickets will be ready over the next few days based on
>> my other email.
>>
>> Cheers, Paul.
>>
>>
>> On Wed, May 3, 2017 at 1:40 AM, Yazad Khambata <ya...@gmail.com> wrote:
>>>
>>> Hi,
>>>
>>> I have been looking around to see if there some simple items I can
>>> pick up to make some initial contributions. I see 3 trivial tickets
>>> that I can work on if that's ok,
>>>
>>> GROOVY-7388
>>> DefaultGroovyMethods class's plus(T[] left, xxxx<T> right) have ambiguous
>>> errors
>>>
>>> In this ticket I see Paul has requested a test case and has not
>>> received a response, I could look at providing a test case and a fix
>>> for this. Note I see that there also a duplicate filed but that is
>>> closed without any work-log or comments.
>>>
>>> GROOVY-5227
>>> AbstractHttpServlet should extend GenericServlet directly instead of
>>> HttpServlet
>>>
>>> Looks like this is one of the tickets where I may be able to provide
>>> some analysis and suggestions and based on that a decision can be made
>>> to either close it or implement it.
>>>
>>> Both tickets have had some comments in 2016 but don't seem to have an
>>> owner. Please let me know if I can pick them up. Thank you.
>>>
>>> Regards,
>>> Yazad Khambata
>>
>>
>
Re: Some trivial tickets
Posted by Yazad Khambata <ya...@gmail.com>.
Thank you.
Regards,
Yazad Khambata
On Mon, Jun 19, 2017 at 5:23 AM Paul King <pa...@asert.com.au> wrote:
> I'll make some time tomorrow to take a look.
>
> Cheers, Paul.
>
> On Mon, Jun 19, 2017 at 12:37 PM, Yazad Khambata <ya...@gmail.com> wrote:
>
>> Hi Paul,
>>
>> Just wanted to check if you are good with the analysis provided for,
>>
>> GROOVY-5227 - AbstractHttpServlet should extend GenericServlet
>> directly instead of HttpServlet
>>
>> Please suggest if you'd like to fix or close based on the analysis and
>> suggestions provided in the comments.
>>
>> Also as the next ticket I was wondering if I could take up,
>>
>> GROOVY-6485 - Replace usage of String#toUpperCase() with
>> String#toUpperCase(Locale.ENGLISH)
>>
>> Thank you.
>>
>> Regards,
>> Yazad Khambata
>>
>>
>>
>> On Thu, May 4, 2017 at 8:56 AM, Yazad Khambata <ya...@gmail.com> wrote:
>> > Forwarded broken chain earlier.
>> >
>> > ---------- Forwarded message ---------
>> > From: Yazad Khambata <ya...@gmail.com>
>> > Date: Thu, May 4, 2017 at 6:00 AM
>> > Subject: Re: Some trivial tickets
>> > To: <pa...@asert.com.au>
>> >
>> >
>> > Hi Paul,
>> >
>> > Awesome, I will provide my analysis on GROOVY-5227 soon. Thank you!
>> >
>> > Regards,
>> >
>> > On Thu, May 4, 2017 at 2:06 AM Paul King <pa...@asert.com.au> wrote:
>> >>
>> >>
>> >> Hi Yazad,
>> >>
>> >> I wouldn't bother with GROOVY-7388. I can imagine some scenarios where
>> >> ambiguous messages might occur but they wouldn't involve normal usage
>> of
>> >> those methods. I have closed for now. If the OP provides more
>> information we
>> >> can pursue that one.
>> >>
>> >> GROOVY-5227 seems worthy of investigation. An analysis would be great.
>> >>
>> >> Hopefully some more tickets will be ready over the next few days based
>> on
>> >> my other email.
>> >>
>> >> Cheers, Paul.
>> >>
>> >>
>> >> On Wed, May 3, 2017 at 1:40 AM, Yazad Khambata <ya...@gmail.com>
>> wrote:
>> >>>
>> >>> Hi,
>> >>>
>> >>> I have been looking around to see if there some simple items I can
>> >>> pick up to make some initial contributions. I see 3 trivial tickets
>> >>> that I can work on if that's ok,
>> >>>
>> >>> GROOVY-7388
>> >>> DefaultGroovyMethods class's plus(T[] left, xxxx<T> right) have
>> ambiguous
>> >>> errors
>> >>>
>> >>> In this ticket I see Paul has requested a test case and has not
>> >>> received a response, I could look at providing a test case and a fix
>> >>> for this. Note I see that there also a duplicate filed but that is
>> >>> closed without any work-log or comments.
>> >>>
>> >>> GROOVY-5227
>> >>> AbstractHttpServlet should extend GenericServlet directly instead of
>> >>> HttpServlet
>> >>>
>> >>> Looks like this is one of the tickets where I may be able to provide
>> >>> some analysis and suggestions and based on that a decision can be made
>> >>> to either close it or implement it.
>> >>>
>> >>> Both tickets have had some comments in 2016 but don't seem to have an
>> >>> owner. Please let me know if I can pick them up. Thank you.
>> >>>
>> >>> Regards,
>> >>> Yazad Khambata
>> >>
>> >>
>> >
>>
>
>
Re: Some trivial tickets
Posted by Paul King <pa...@asert.com.au>.
I'll make some time tomorrow to take a look.
Cheers, Paul.
On Mon, Jun 19, 2017 at 12:37 PM, Yazad Khambata <ya...@gmail.com> wrote:
> Hi Paul,
>
> Just wanted to check if you are good with the analysis provided for,
>
> GROOVY-5227 - AbstractHttpServlet should extend GenericServlet
> directly instead of HttpServlet
>
> Please suggest if you'd like to fix or close based on the analysis and
> suggestions provided in the comments.
>
> Also as the next ticket I was wondering if I could take up,
>
> GROOVY-6485 - Replace usage of String#toUpperCase() with
> String#toUpperCase(Locale.ENGLISH)
>
> Thank you.
>
> Regards,
> Yazad Khambata
>
>
>
> On Thu, May 4, 2017 at 8:56 AM, Yazad Khambata <ya...@gmail.com> wrote:
> > Forwarded broken chain earlier.
> >
> > ---------- Forwarded message ---------
> > From: Yazad Khambata <ya...@gmail.com>
> > Date: Thu, May 4, 2017 at 6:00 AM
> > Subject: Re: Some trivial tickets
> > To: <pa...@asert.com.au>
> >
> >
> > Hi Paul,
> >
> > Awesome, I will provide my analysis on GROOVY-5227 soon. Thank you!
> >
> > Regards,
> >
> > On Thu, May 4, 2017 at 2:06 AM Paul King <pa...@asert.com.au> wrote:
> >>
> >>
> >> Hi Yazad,
> >>
> >> I wouldn't bother with GROOVY-7388. I can imagine some scenarios where
> >> ambiguous messages might occur but they wouldn't involve normal usage of
> >> those methods. I have closed for now. If the OP provides more
> information we
> >> can pursue that one.
> >>
> >> GROOVY-5227 seems worthy of investigation. An analysis would be great.
> >>
> >> Hopefully some more tickets will be ready over the next few days based
> on
> >> my other email.
> >>
> >> Cheers, Paul.
> >>
> >>
> >> On Wed, May 3, 2017 at 1:40 AM, Yazad Khambata <ya...@gmail.com>
> wrote:
> >>>
> >>> Hi,
> >>>
> >>> I have been looking around to see if there some simple items I can
> >>> pick up to make some initial contributions. I see 3 trivial tickets
> >>> that I can work on if that's ok,
> >>>
> >>> GROOVY-7388
> >>> DefaultGroovyMethods class's plus(T[] left, xxxx<T> right) have
> ambiguous
> >>> errors
> >>>
> >>> In this ticket I see Paul has requested a test case and has not
> >>> received a response, I could look at providing a test case and a fix
> >>> for this. Note I see that there also a duplicate filed but that is
> >>> closed without any work-log or comments.
> >>>
> >>> GROOVY-5227
> >>> AbstractHttpServlet should extend GenericServlet directly instead of
> >>> HttpServlet
> >>>
> >>> Looks like this is one of the tickets where I may be able to provide
> >>> some analysis and suggestions and based on that a decision can be made
> >>> to either close it or implement it.
> >>>
> >>> Both tickets have had some comments in 2016 but don't seem to have an
> >>> owner. Please let me know if I can pick them up. Thank you.
> >>>
> >>> Regards,
> >>> Yazad Khambata
> >>
> >>
> >
>