You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/01/06 21:54:29 UTC

[GitHub] [helix] pkuwm opened a new issue #1601: Include Exception Message in Log of ZkBaseDataAccessor#get()

pkuwm opened a new issue #1601:
URL: https://github.com/apache/helix/issues/1601


   ### Description
   Today, when I was debugging a zk serializer issue, I noticed that the thrown exception in 
   ZkBaseDataAccessor#get(List<String> paths, List<Stat> stats, boolean[] needRead, boolean throwException)
   doesn't contain the right error message.
   Here is the current code:
   ```
   catch (Exception e) {
     throw new HelixMetaDataAccessException(String.format("Fail to read nodes for %s", paths));
   } finally {
   ```
   Could you please include the error message extracted from the caught Exception in the newly thrown HelixMetaDataAccessException?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] pkuwm closed issue #1601: Include Exception Message in Log of ZkBaseDataAccessor#get()

Posted by GitBox <gi...@apache.org>.
pkuwm closed issue #1601:
URL: https://github.com/apache/helix/issues/1601


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] pkuwm commented on issue #1601: Include Exception Message in Log of ZkBaseDataAccessor#get()

Posted by GitBox <gi...@apache.org>.
pkuwm commented on issue #1601:
URL: https://github.com/apache/helix/issues/1601#issuecomment-759114018


   Will be fixed by #1609 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] pkuwm commented on issue #1601: Include Exception Message in Log of ZkBaseDataAccessor#get()

Posted by GitBox <gi...@apache.org>.
pkuwm commented on issue #1601:
URL: https://github.com/apache/helix/issues/1601#issuecomment-774309231


    fixed by #1609


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org