You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by Andreas Hartmann <an...@apache.org> on 2007/05/22 14:17:40 UTC
Use UUID-based URLs in navigation elements?
Hi Lenya devs,
there's a pending patch which changes the sitetree2nav.xsl stylesheet
so that it doesn't use absolute URLs in the href attributes of
navigation elements, but lenya-document:{uuid} URIs.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42050#c14
Pros:
- code simplification (look at the minus signs in the patch)
- better SoC - URL building is left to the UuidToUrlTransformer
Cons:
- not thorougly tested yet
- because the sitetree module API has changed, calls to navigation
elements have to be updated
Shall we apply this patch?
If yes, shall I commit it now, or wait until 1.4 is released?
-- Andreas
--
Andreas Hartmann, CTO
BeCompany GmbH
http://www.becompany.ch
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: Use UUID-based URLs in navigation elements?
Posted by Andreas Hartmann <an...@apache.org>.
Andreas Hartmann schrieb:
> Hi Lenya devs,
>
> there's a pending patch which changes the sitetree2nav.xsl stylesheet
> so that it doesn't use absolute URLs in the href attributes of
> navigation elements, but lenya-document:{uuid} URIs.
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=42050#c14
>
>
> Pros:
>
> - code simplification (look at the minus signs in the patch)
>
> - better SoC - URL building is left to the UuidToUrlTransformer
Another advantage:
- because no URLs are evaluated in sitetree2nav.xsl anymore, the
nav elements become independent from the URL space, e.g. the
language suffix style doesn't matter.
> Cons:
>
> - not thorougly tested yet
>
> - because the sitetree module API has changed, calls to navigation
> elements have to be updated
>
>
> Shall we apply this patch?
> If yes, shall I commit it now, or wait until 1.4 is released?
>
> -- Andreas
>
--
Andreas Hartmann, CTO
BeCompany GmbH
http://www.becompany.ch
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: Use UUID-based URLs in navigation elements?
Posted by Andreas Hartmann <an...@apache.org>.
Andreas Hartmann schrieb:
> Hi Lenya devs,
>
> there's a pending patch which changes the sitetree2nav.xsl stylesheet
> so that it doesn't use absolute URLs in the href attributes of
> navigation elements, but lenya-document:{uuid} URIs.
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=42050#c14
>
>
> Pros:
>
> - code simplification (look at the minus signs in the patch)
>
> - better SoC - URL building is left to the UuidToUrlTransformer
Here's another one:
- better performance, since quite a lot of string manipulation and
recursive template calls, which had to be executed for each navigation
element, can be removed
-- Andreas
--
Andreas Hartmann, CTO
BeCompany GmbH
http://www.becompany.ch
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: Use UUID-based URLs in navigation elements?
Posted by Joern Nettingsmeier <ne...@folkwang-hochschule.de>.
Andreas Hartmann wrote:
> Jörn Nettingsmeier schrieb:
>> Andreas Hartmann wrote:
>>> Hi Lenya devs,
>>>
>>> there's a pending patch which changes the sitetree2nav.xsl stylesheet
>>> so that it doesn't use absolute URLs in the href attributes of
>>> navigation elements, but lenya-document:{uuid} URIs.
>
> I tested this for a while now, and didn't notice any problems.
>
> Does someone mind if I commit it?
>
> I'll add a note about the changes to the readme file then.
i ran it only very briefly, but it works for me. +1 for committing it.
the readme will warn our early adopters, and if there are any bugs, they
should be obvious and easy to fix.
--
jörn nettingsmeier
home://germany/45128 essen/lortzingstr. 11/
http://spunk.dnsalias.org
phone://+49/201/491621
Kurt is up in Heaven now.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: Use UUID-based URLs in navigation elements?
Posted by Andreas Hartmann <an...@apache.org>.
Jörn Nettingsmeier schrieb:
> Andreas Hartmann wrote:
>> Hi Lenya devs,
>>
>> there's a pending patch which changes the sitetree2nav.xsl stylesheet
>> so that it doesn't use absolute URLs in the href attributes of
>> navigation elements, but lenya-document:{uuid} URIs.
I tested this for a while now, and didn't notice any problems.
Does someone mind if I commit it?
I'll add a note about the changes to the readme file then.
-- Andreas
--
Andreas Hartmann, CTO
BeCompany GmbH
http://www.becompany.ch
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: Use UUID-based URLs in navigation elements?
Posted by Jörn Nettingsmeier <ne...@apache.org>.
Andreas Hartmann wrote:
> Hi Lenya devs,
>
> there's a pending patch which changes the sitetree2nav.xsl stylesheet
> so that it doesn't use absolute URLs in the href attributes of
> navigation elements, but lenya-document:{uuid} URIs.
lovely idea. i'll test it tomorrow.
> http://issues.apache.org/bugzilla/show_bug.cgi?id=42050#c14
>
>
> Pros:
>
> - code simplification (look at the minus signs in the patch)
:)
> - better SoC - URL building is left to the UuidToUrlTransformer
>
>
> Cons:
>
> - not thorougly tested yet
let's change that. since this is a local change, i think we can be
reasonably certain we won't have and hard-to-fix side effects once the
bugs in the patch itself are found (if any).
> - because the sitetree module API has changed, calls to navigation
> elements have to be updated
that is an argument for doing it now, so that users won't have to make
changes during the stable release cycle.
it's another strain on our beta testers, but i'm buying every beta
tester who makes it to zurich a beer for compensation :)
> Shall we apply this patch?
> If yes, shall I commit it now, or wait until 1.4 is released?
haven't reviewed and tried it yet, but i like the idea a lot.
--
Jörn Nettingsmeier
Kurt is up in heaven now.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: Use UUID-based URLs in navigation elements?
Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Tue, 2007-05-22 at 14:17 +0200, Andreas Hartmann wrote:
> Hi Lenya devs,
>
> there's a pending patch which changes the sitetree2nav.xsl stylesheet
> so that it doesn't use absolute URLs in the href attributes of
> navigation elements, but lenya-document:{uuid} URIs.
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=42050#c14
Will test it now.
Can you have a look at the proxyTransformer?
salu2
--
Thorsten Scherler thorsten.at.apache.org
Open Source Java consulting, training and solutions
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org