You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uniffle.apache.org by ro...@apache.org on 2022/08/22 15:30:26 UTC
[incubator-uniffle] 01/01: Revert "[ISSUE-173][FOLLOWUP] The size of single buffer flush should reach rss.server.flush.cold.storage.threshold.size (#178)"
This is an automated email from the ASF dual-hosted git repository.
roryqi pushed a commit to branch revert-178-follow_issue_173
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git
commit eecf9a277068d27a87905e5f50c65ea896e79f2b
Author: roryqi <je...@gmail.com>
AuthorDate: Mon Aug 22 23:30:20 2022 +0800
Revert "[ISSUE-173][FOLLOWUP] The size of single buffer flush should reach rss.server.flush.cold.storage.threshold.size (#178)"
This reverts commit ab6be6ed4ab0d8bfe4bbcf26c6597ded28a0c1aa.
---
.../java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java b/server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java
index 660cd5c5..f934f0f6 100644
--- a/server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java
+++ b/server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java
@@ -165,9 +165,7 @@ public class ShuffleBufferManager {
void flushSingleBufferIfNecessary(ShuffleBuffer buffer, String appId,
int shuffleId, int startPartition, int endPartition) {
- // When we use multistorage and trigger single buffer flush, the buffer size should be bigger
- // than rss.server.flush.cold.storage.threshold.size, otherwise cold storage will be useless.
- if (this.bufferFlushEnabled && buffer.getSize() > this.bufferFlushThreshold) {
+ if (this.bufferFlushEnabled && buffer.getSize() >= this.bufferFlushThreshold) {
flushBuffer(buffer, appId, shuffleId, startPartition, endPartition);
}
}