[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #7175: Core, Spark 3.3: Add FileRewriter API

["aokolnychyi (via GitHub)" <gi...@apache.org>]

aokolnychyi commented on code in PR #7175:
URL: https://github.com/apache/iceberg/pull/7175#discussion_r1145536996


##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -124,6 +123,8 @@
                 org.apache.iceberg.TableProperties.*,
                 org.apache.iceberg.types.Type.*,
                 org.apache.iceberg.types.Types.NestedField.*,
+                org.apache.iceberg.relocated.com.google.common.base.Preconditions.*,

Review Comment:
   I added these static imports as the new line limit applies weird formatting in places when statements don't fit on a single line. We have no control over that formatting and having static imports would allow more statements to fit on a single line. It is very common for projects to allow certain static imports for commonly used methods. For instance, Trino also allows static imports for `Preconditions`, just like I added here. We should be careful with allowed static imports but I feel these particular ones will not add any confusion to the code. The problem with static imports is when the context is not clear, which I don't think applies here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org