You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by mp...@apache.org on 2017/01/24 03:02:49 UTC
[2/2] mesos git commit: Fixed a typo in `src/master/http.cpp`.
Fixed a typo in `src/master/http.cpp`.
Review: https://reviews.apache.org/r/55554/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/90ed0484
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/90ed0484
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/90ed0484
Branch: refs/heads/master
Commit: 90ed0484a035b82f7a4a5bd5a8125206f1f8048f
Parents: f737e93
Author: Jay Guo <gu...@gmail.com>
Authored: Mon Jan 23 19:01:30 2017 -0800
Committer: Michael Park <mp...@apache.org>
Committed: Mon Jan 23 19:02:13 2017 -0800
----------------------------------------------------------------------
src/master/http.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/90ed0484/src/master/http.cpp
----------------------------------------------------------------------
diff --git a/src/master/http.cpp b/src/master/http.cpp
index add88e1..a455f03 100644
--- a/src/master/http.cpp
+++ b/src/master/http.cpp
@@ -233,7 +233,7 @@ struct FullFrameworkWriter {
}
// For multi-role frameworks the `role` field will be unset.
- // Note that we could set `roles` here both both cases, which
+ // Note that we could set `roles` here for both cases, which
// would make tooling simpler (only need to look for `roles`).
// However, we opted to just mirror the protobuf akin to how
// generic protobuf -> JSON translation works.
Re: [2/2] mesos git commit: Fixed a typo in `src/master/http.cpp`.
Posted by Neil Conway <ne...@gmail.com>.
The same typo occurs in slave/http.cpp.
Neil
On Mon, Jan 23, 2017 at 7:02 PM, <mp...@apache.org> wrote:
> Fixed a typo in `src/master/http.cpp`.
>
> Review: https://reviews.apache.org/r/55554/
>
>
> Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
> Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/90ed0484
> Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/90ed0484
> Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/90ed0484
>
> Branch: refs/heads/master
> Commit: 90ed0484a035b82f7a4a5bd5a8125206f1f8048f
> Parents: f737e93
> Author: Jay Guo <gu...@gmail.com>
> Authored: Mon Jan 23 19:01:30 2017 -0800
> Committer: Michael Park <mp...@apache.org>
> Committed: Mon Jan 23 19:02:13 2017 -0800
>
> ----------------------------------------------------------------------
> src/master/http.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/mesos/blob/90ed0484/src/master/http.cpp
> ----------------------------------------------------------------------
> diff --git a/src/master/http.cpp b/src/master/http.cpp
> index add88e1..a455f03 100644
> --- a/src/master/http.cpp
> +++ b/src/master/http.cpp
> @@ -233,7 +233,7 @@ struct FullFrameworkWriter {
> }
>
> // For multi-role frameworks the `role` field will be unset.
> - // Note that we could set `roles` here both both cases, which
> + // Note that we could set `roles` here for both cases, which
> // would make tooling simpler (only need to look for `roles`).
> // However, we opted to just mirror the protobuf akin to how
> // generic protobuf -> JSON translation works.
>