[jira] [Commented] (HDFS-11491) Ozone: Add close container RPC

["Xiaoyu Yao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-11491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923143#comment-15923143 ] 

Xiaoyu Yao commented on HDFS-11491:
-----------------------------------

Thanks [~anu] for working on this. The patch looks great to me. I just have two minor questions. +1 otherwise.

ContainerData.java 
Line 75: should we check if protoData has Open flag?
Line 76: should we setHash() if protoData has a hash?

ContainerManagerImpl.java
Line 468: typo “damanged”


> Ozone: Add close container RPC 
> -------------------------------
>
>                 Key: HDFS-11491
>                 URL: https://issues.apache.org/jira/browse/HDFS-11491
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-11491-HDFS-7240.001.patch
>
>
> A container can be in open state or closed state. A closed container is immutable. This immutability makes it easy to operate upon the container. Things like storing a container in an erasure coded format is much easier once a container is closed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org