You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/21 18:20:40 UTC
[GitHub] [kafka] lihaosky opened a new pull request, #13034: MINOR: remove onChange call in stream assignor assign method
lihaosky opened a new pull request, #13034:
URL: https://github.com/apache/kafka/pull/13034
## Description
Remove unnecessary calls in assign method
## Test
Existing tests
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei merged pull request #13034: MINOR: remove onChange call in stream assignor assign method
Posted by GitBox <gi...@apache.org>.
vvcephei merged PR #13034:
URL: https://github.com/apache/kafka/pull/13034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #13034: MINOR: remove onChange call in stream assignor assign method
Posted by GitBox <gi...@apache.org>.
vvcephei commented on PR #13034:
URL: https://github.com/apache/kafka/pull/13034#issuecomment-1362253175
None of the failing tests were from Streams:
```
Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testReplication() | 2 min 11 sec | 1
-- | -- | --
Build / JDK 11 and Scala 2.13 / kafka.api.TransactionsExpirationTest.testTransactionAfterProducerIdExpires(String).quorum=kraft | 10 sec | 1
Build / JDK 11 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testTrustStoreAlter(String).quorum=kraft | 4.5 sec | 1
Build / JDK 17 and Scala 2.13 / org.apache.kafka.common.network.Tls12SelectorTest.testCloseOldestConnection() | 0.59 sec | 1
Build / JDK 17 and Scala 2.13 / kafka.admin.ReassignPartitionsIntegrationTest.testCancellation(String).quorum=kraft | 16 sec | 1
Build / JDK 17 and Scala 2.13 / kafka.api.ProducerIdExpirationTest.testProducerIdExpirationWithNoTransactions(String).quorum=zk | 5.4 sec | 1
Build / JDK 17 and Scala 2.13 / kafka.api.TransactionsTest.testSendOffsetsWithGroupId(String).quorum=kraft
[Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testReplication()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13034/1/testReport/org.apache.kafka.connect.mirror.integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest/Build___JDK_11_and_Scala_2_13___testReplication__/) 2 min 11 sec [1](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13034/1/)
[Build / JDK 11 and Scala 2.13 / kafka.api.TransactionsExpirationTest.testTransactionAfterProducerIdExpires(String).quorum=kraft](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13034/1/testReport/kafka.api/TransactionsExpirationTest/Build___JDK_11_and_Scala_2_13___testTransactionAfterProducerIdExpires_String__quorum_kraft/) 10 sec [1](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13034/1/)
[Build / JDK 11 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testTrustStoreAlter(String).quorum=kraft](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13034/1/testReport/kafka.server/DynamicBrokerReconfigurationTest/Build___JDK_11_and_Scala_2_13___testTrustStoreAlter_String__quorum_kraft/) 4.5 sec [1](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13034/1/)
[Build / JDK 17 and Scala 2.13 / org.apache.kafka.common.network.Tls12SelectorTest.testCloseOldestConnection()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13034/1/testReport/org.apache.kafka.common.network/Tls12SelectorTest/Build___JDK_17_and_Scala_2_13___testCloseOldestConnection__/) 0.59 sec [1](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13034/1/)
[Build / JDK 17 and Scala 2.13 / kafka.admin.ReassignPartitionsIntegrationTest.testCancellation(String).quorum=kraft](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13034/1/testReport/kafka.admin/ReassignPartitionsIntegrationTest/Build___JDK_17_and_Scala_2_13___testCancellation_String__quorum_kraft/) 16 sec [1](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13034/1/)
[Build / JDK 17 and Scala 2.13 / kafka.api.ProducerIdExpirationTest.testProducerIdExpirationWithNoTransactions(String).quorum=zk](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13034/1/testReport/kafka.api/ProducerIdExpirationTest/Build___JDK_17_and_Scala_2_13___testProducerIdExpirationWithNoTransactions_String__quorum_zk/) 5.4 sec [1](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13034/1/)
[Build / JDK 17 and Scala 2.13 / kafka.api.TransactionsTest.testSendOffsetsWithGroupId(String).quorum=kraft](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13034/1/testReport/kafka.api/TransactionsTest/Build___JDK_17_and_Scala_2_13___testSendOffsetsWithGroupId_String__quorum_kraft/)
```
I'll go ahead and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org