You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jeff Coffler <je...@taltos.com> on 2017/10/11 23:31:34 UTC
Re: Review Request 60626: Eliminated os::shell calls from HDFS for
Windows compatibility.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60626/
-----------------------------------------------------------
(Updated Oct. 11, 2017, 11:31 p.m.)
Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
Summary (updated)
-----------------
Eliminated os::shell calls from HDFS for Windows compatibility.
Bugs: MESOS-6705
https://issues.apache.org/jira/browse/MESOS-6705
Repository: mesos
Description (updated)
-------
Eliminated os::shell calls from HDFS for Windows compatibility.
Diffs (updated)
-----
src/hdfs/hdfs.cpp 2c95a5ea43a4289e1168c527b9ccc35690a751a4
Diff: https://reviews.apache.org/r/60626/diff/3/
Changes: https://reviews.apache.org/r/60626/diff/2-3/
Testing
-------
See upstream
Thanks,
Jeff Coffler
Re: Review Request 60626: Eliminated os::shell calls from HDFS for
Windows compatibility.
Posted by Jeff Coffler <je...@taltos.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60626/
-----------------------------------------------------------
(Updated Oct. 19, 2017, 9:33 p.m.)
Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
Bugs: MESOS-6705
https://issues.apache.org/jira/browse/MESOS-6705
Repository: mesos
Description
-------
Windows doesn't support os::shell calls, so reworked the code to use
libprocess instead.
Diffs (updated)
-----
src/hdfs/hdfs.cpp 2c95a5ea43a4289e1168c527b9ccc35690a751a4
Diff: https://reviews.apache.org/r/60626/diff/6/
Changes: https://reviews.apache.org/r/60626/diff/5-6/
Testing
-------
See upstream
Thanks,
Jeff Coffler
Re: Review Request 60626: Eliminated os::shell calls from HDFS for
Windows compatibility.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60626/#review188763
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On Oct. 19, 2017, 11:17 a.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60626/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 11:17 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-6705
> https://issues.apache.org/jira/browse/MESOS-6705
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows doesn't support os::shell calls, so reworked the code to use
> libprocess instead.
>
>
> Diffs
> -----
>
> src/hdfs/hdfs.cpp 2c95a5ea43a4289e1168c527b9ccc35690a751a4
>
>
> Diff: https://reviews.apache.org/r/60626/diff/5/
>
>
> Testing
> -------
>
> See upstream
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 60626: Eliminated os::shell calls from HDFS for
Windows compatibility.
Posted by Jeff Coffler <je...@taltos.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60626/
-----------------------------------------------------------
(Updated Oct. 19, 2017, 6:17 p.m.)
Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
Bugs: MESOS-6705
https://issues.apache.org/jira/browse/MESOS-6705
Repository: mesos
Description (updated)
-------
Windows doesn't support os::shell calls, so reworked the code to use
libprocess instead.
Diffs (updated)
-----
src/hdfs/hdfs.cpp 2c95a5ea43a4289e1168c527b9ccc35690a751a4
Diff: https://reviews.apache.org/r/60626/diff/5/
Changes: https://reviews.apache.org/r/60626/diff/4-5/
Testing
-------
See upstream
Thanks,
Jeff Coffler
Re: Review Request 60626: Eliminated os::shell calls from HDFS for
Windows compatibility.
Posted by Jeff Coffler <je...@taltos.com>.
> On Oct. 18, 2017, 12:45 a.m., Andrew Schwartzmeyer wrote:
> > Needs a description still.
Ok.
> On Oct. 18, 2017, 12:45 a.m., Andrew Schwartzmeyer wrote:
> > src/hdfs/hdfs.cpp
> > Lines 125-134 (patched)
> > <https://reviews.apache.org/r/60626/diff/4/?file=1858873#file1858873line125>
> >
> > nit: Maybe it's just me, but this could just be `Option<int> status` and then `status.get()` below; that's _usually_ how it's done in the codebase.
Could have. But I don't like the idea of resolving get() multiple times. Six of one, dozen of another. I'll leave this one to Joe to change if he wants.
- Jeff
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60626/#review188428
-----------------------------------------------------------
On Oct. 17, 2017, 1:19 a.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60626/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 1:19 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-6705
> https://issues.apache.org/jira/browse/MESOS-6705
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Eliminated os::shell calls from HDFS for Windows compatibility.
>
>
> Diffs
> -----
>
> src/hdfs/hdfs.cpp 2c95a5ea43a4289e1168c527b9ccc35690a751a4
>
>
> Diff: https://reviews.apache.org/r/60626/diff/4/
>
>
> Testing
> -------
>
> See upstream
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 60626: Eliminated os::shell calls from HDFS for
Windows compatibility.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60626/#review188428
-----------------------------------------------------------
Needs a description still.
src/hdfs/hdfs.cpp
Lines 125-134 (patched)
<https://reviews.apache.org/r/60626/#comment265423>
nit: Maybe it's just me, but this could just be `Option<int> status` and then `status.get()` below; that's _usually_ how it's done in the codebase.
- Andrew Schwartzmeyer
On Oct. 16, 2017, 6:19 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60626/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2017, 6:19 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-6705
> https://issues.apache.org/jira/browse/MESOS-6705
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Eliminated os::shell calls from HDFS for Windows compatibility.
>
>
> Diffs
> -----
>
> src/hdfs/hdfs.cpp 2c95a5ea43a4289e1168c527b9ccc35690a751a4
>
>
> Diff: https://reviews.apache.org/r/60626/diff/4/
>
>
> Testing
> -------
>
> See upstream
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 60626: Eliminated os::shell calls from HDFS for
Windows compatibility.
Posted by Jeff Coffler <je...@taltos.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60626/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 1:19 a.m.)
Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
Bugs: MESOS-6705
https://issues.apache.org/jira/browse/MESOS-6705
Repository: mesos
Description
-------
Eliminated os::shell calls from HDFS for Windows compatibility.
Diffs (updated)
-----
src/hdfs/hdfs.cpp 2c95a5ea43a4289e1168c527b9ccc35690a751a4
Diff: https://reviews.apache.org/r/60626/diff/4/
Changes: https://reviews.apache.org/r/60626/diff/3-4/
Testing
-------
See upstream
Thanks,
Jeff Coffler