You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Joshua McKenzie (JIRA)" <ji...@apache.org> on 2014/05/01 01:58:16 UTC

[jira] [Commented] (CASSANDRA-3668) Parallel streaming for sstableloader

    [ https://issues.apache.org/jira/browse/CASSANDRA-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986225#comment-13986225 ] 

Joshua McKenzie commented on CASSANDRA-3668:
--------------------------------------------

Looks good - I went back and forth between re-using those data structures in the StreamCoordinator vs. limiting its scope to the StreamResultFuture only during implementation.  While this approach has a touch of duplication to it I think it's fine in order to keep the scope limited.

Test of v3 looks good.  I'm getting some NPE's from SSTableReader.scheduleTidy closing up IndexSummaries but I don't think that has anything to do with this patch.

+1

> Parallel streaming for sstableloader
> ------------------------------------
>
>                 Key: CASSANDRA-3668
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3668
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: API
>            Reporter: Manish Zope
>            Assignee: Joshua McKenzie
>            Priority: Minor
>              Labels: streaming
>             Fix For: 2.1 rc1
>
>         Attachments: 3668-1.1-v2.txt, 3668-1.1.txt, 3668-v3.txt, 3668_v2.txt, 3688-reply_before_closing_writer.txt, sstable-loader performance.txt
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> One of my colleague had reported the bug regarding the degraded performance of the sstable generator and sstable loader.
> ISSUE :- https://issues.apache.org/jira/browse/CASSANDRA-3589 
> As stated in above issue generator performance is rectified but performance of the sstableloader is still an issue.
> 3589 is marked as duplicate of 3618.Both issues shows resolved status.But the problem with sstableloader still exists.
> So opening other issue so that sstbleloader problem should not go unnoticed.
> FYI : We have tested the generator part with the patch given in 3589.Its Working fine.
> Please let us know if you guys require further inputs from our side.



--
This message was sent by Atlassian JIRA
(v6.2#6252)