You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Ross Gardler (JIRA)" <ji...@apache.org> on 2005/07/26 19:26:20 UTC

[jira] Created: (FOR-587) Locationmap view does not display locationmap

Locationmap view does not display locationmap
---------------------------------------------

         Key: FOR-587
         URL: http://issues.apache.org/jira/browse/FOR-587
     Project: Forrest
        Type: Bug
    Reporter: Ross Gardler


I can enable the locationmap view in Eclipse, however, it never displays the details of a  locationmap for the selected project.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Created: (FOR-587) Locationmap view does not display locationmap

Posted by Ross Gardler <rg...@apache.org>.
Anil Ramnanan wrote:
> Ross Gardler (JIRA) wrote:
> 
>> I can enable the locationmap view in Eclipse, however, it never 
>> displays the details of a locationmap for the selected project.
>>
>>  
>>
> Are there any error messages in the console ? It works fine here.

I've not attempted to debug yet. I'll try and provide more info. on the 
issue.

Ross

Re: [jira] Created: (FOR-587) Locationmap view does not display locationmap

Posted by Anil Ramnanan <li...@peppersauce.org>.
Ross Gardler (JIRA) wrote:

>I can enable the locationmap view in Eclipse, however, it never displays the details of a locationmap for the selected project.
>
>  
>
Are there any error messages in the console ? It works fine here.

Anil.

[jira] Commented: (FOR-587) Locationmap view does not display locationmap

Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-587?page=comments#action_12317343 ] 

Ross Gardler commented on FOR-587:
----------------------------------

I've had a bit more of a play with this. It correctly displays the locationmap if I select the root of the project, but if I select a file in the project it does not work.

The problem also exists for the tabs.xml and site.xml viewers method, in particular the line:

if (resource instanceof IProject)

Notice we are looking to see if the selection is an IProject (i.e. a root node).

For an example of how this can be done more robustly see my work on the IMS Editor in the Burrokeet project (permission granted to copy code from there if it helps): http://cvs.sourceforge.net/viewcvs.py/burrokeet/org.burrokeet.contentPackage.scorm.editor/src/org/imsproject/xsd/imscpRootv1p1p2/presentation/ImscpRootv1p1p2View.java?rev=1.47&view=markup

Note that this code not only works for any element selected in the tree, but also verifies that the selected project has the correct nature before attempting to load the resource (important from a performance perspective).

Finally, I not the locationmap is not using the superclass NavigationView. I created this class to collect common code between views for navigation config files. One of these is the selection changed event. If the locationmap view is modified to extend this class then there is only one place we need to make these changes and all three views will work correctly (this is easy to do since the code in this method looks like it was cut and pasted from the super class anyway).

> Locationmap view does not display locationmap
> ---------------------------------------------
>
>          Key: FOR-587
>          URL: http://issues.apache.org/jira/browse/FOR-587
>      Project: Forrest
>         Type: Bug
>     Reporter: Ross Gardler

>
> I can enable the locationmap view in Eclipse, however, it never displays the details of a  locationmap for the selected project.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (FOR-587) Locationmap view does not display locationmap

Posted by "Anil Ramnanan (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FOR-587?page=all ]

Anil Ramnanan updated FOR-587:
------------------------------

    Attachment: navigationView.010805.diff

Made the change to the navigationView class to properly open files when a project is selected.

> Locationmap view does not display locationmap
> ---------------------------------------------
>
>          Key: FOR-587
>          URL: http://issues.apache.org/jira/browse/FOR-587
>      Project: Forrest
>         Type: Bug
>     Reporter: Ross Gardler
>  Attachments: navigationView.010805.diff
>
> I can enable the locationmap view in Eclipse, however, it never displays the details of a  locationmap for the selected project.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (FOR-587) Locationmap view does not display locationmap

Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-587?page=comments#action_12317348 ] 

Ross Gardler commented on FOR-587:
----------------------------------

I've made the locationmap view extend the NavigatorView class so now it is just a case of fixing the selection changed event in NavigatorView.java

> Locationmap view does not display locationmap
> ---------------------------------------------
>
>          Key: FOR-587
>          URL: http://issues.apache.org/jira/browse/FOR-587
>      Project: Forrest
>         Type: Bug
>     Reporter: Ross Gardler

>
> I can enable the locationmap view in Eclipse, however, it never displays the details of a  locationmap for the selected project.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (FOR-587) Locationmap view does not display locationmap

Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FOR-587?page=all ]
     
Ross Gardler closed FOR-587:
----------------------------

    Resolution: Fixed
     Assign To: Ross Gardler

Applied this patch with some minor changes:

- removed commented out code that was cut and pasted from an example
- added TODO to check nature of project before load
- corrected javadoc entry

> Locationmap view does not display locationmap
> ---------------------------------------------
>
>          Key: FOR-587
>          URL: http://issues.apache.org/jira/browse/FOR-587
>      Project: Forrest
>         Type: Bug
>     Reporter: Ross Gardler
>     Assignee: Ross Gardler
>  Attachments: navigationView.010805.diff
>
> I can enable the locationmap view in Eclipse, however, it never displays the details of a  locationmap for the selected project.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira