You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/08 10:22:13 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #35626: [SPARK-38240][SQL][FOLLOW-UP] Make RuntimeReplaceableAggregate as an add-on of AggregateFunction
HyukjinKwon commented on a change in pull request #35626:
URL: https://github.com/apache/spark/pull/35626#discussion_r821523410
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/linearRegression.scala
##########
@@ -65,8 +68,13 @@ case class RegrCount(left: Expression, right: Expression)
group = "agg_funcs",
since = "3.3.0")
// scalastyle:on line.size.limit
-case class RegrAvgX(left: Expression, right: Expression)
- extends RuntimeReplaceableAggregate with ImplicitCastInputTypes with BinaryLike[Expression] {
+case class RegrAvgX(
+ left: Expression,
+ right: Expression)
Review comment:
This is actually following DB style guidelines:
> For classes whose header doesn't fit in two lines, use 4 space indentation for its parameters, put each in each line, put the extends on the next line with 2 space indent, and add a blank line after class header.
https://github.com/databricks/scala-style-guide#spacing-and-indentation
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/linearRegression.scala
##########
@@ -65,8 +68,13 @@ case class RegrCount(left: Expression, right: Expression)
group = "agg_funcs",
since = "3.3.0")
// scalastyle:on line.size.limit
-case class RegrAvgX(left: Expression, right: Expression)
- extends RuntimeReplaceableAggregate with ImplicitCastInputTypes with BinaryLike[Expression] {
+case class RegrAvgX(
+ left: Expression,
+ right: Expression)
Review comment:
This is actually following the style guidelines:
> For classes whose header doesn't fit in two lines, use 4 space indentation for its parameters, put each in each line, put the extends on the next line with 2 space indent, and add a blank line after class header.
https://github.com/databricks/scala-style-guide#spacing-and-indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org