[GitHub] [ozone] Tejaskriya commented on pull request #4538: HDDS-7752. GetS3SecretRequest API should not return secret if secret of user already exists

["Tejaskriya (via GitHub)" <gi...@apache.org>]

Tejaskriya commented on PR #4538:
URL: https://github.com/apache/ozone/pull/4538#issuecomment-1689318441

   > The impact on tenant getsecret could be a deal-breaker. See:
   > 
   > [#4538 (comment)](https://github.com/apache/ozone/pull/4538#discussion_r1161453347)
   > 
   > The best course of action in this PR is to allow `tenant user getsecret` to behave as-is by checking whether the `accessId` belongs to a tenant. (And maybe tackle that later on in another PR if necessary @prashantpogde )
   
   IMO, it's preferred to keep the behaviour consistent across both `getsecret` requests. As tenant user getsecret always returns a pre-existing secret, can we remove TenantGetSecretHandler instead?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org