You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/05/01 08:55:15 UTC
[GitHub] [incubator-shenyu] dragon-zhang opened a new pull request, #3368: [ISSUE #3367] selector match only once
dragon-zhang opened a new pull request, #3368:
URL: https://github.com/apache/incubator-shenyu/pull/3368
// Describe your PR here; eg. Fixes #3367
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `mvn clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] dragon-zhang commented on pull request #3368: [ISSUE #3367] selector match only once
Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on PR #3368:
URL: https://github.com/apache/incubator-shenyu/pull/3368#issuecomment-1119559677
There is some logic wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #3368: [ISSUE #3367] selector match only once
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3368:
URL: https://github.com/apache/incubator-shenyu/pull/3368#issuecomment-1114194011
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3368?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3368](https://codecov.io/gh/apache/incubator-shenyu/pull/3368?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a87f188) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/d47e617a2eeedb6d9e0aaeb2faf08cc31ad31fa6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d47e617) will **decrease** coverage by `0.00%`.
> The diff coverage is `75.34%`.
```diff
@@ Coverage Diff @@
## master #3368 +/- ##
============================================
- Coverage 65.25% 65.24% -0.01%
- Complexity 5241 5251 +10
============================================
Files 760 760
Lines 21224 21282 +58
Branches 1932 1934 +2
============================================
+ Hits 13849 13885 +36
- Misses 6089 6107 +18
- Partials 1286 1290 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/3368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/shenyu/plugin/base/cache/BaseDataCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3368/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vYmFzZS9jYWNoZS9CYXNlRGF0YUNhY2hlLmphdmE=) | `80.86% <66.66%> (-10.31%)` | :arrow_down: |
| [...pache/shenyu/plugin/base/AbstractShenyuPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3368/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vYmFzZS9BYnN0cmFjdFNoZW55dVBsdWdpbi5qYXZh) | `63.41% <90.00%> (-4.88%)` | :arrow_down: |
| [.../plugin/base/condition/strategy/MatchStrategy.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3368/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vYmFzZS9jb25kaXRpb24vc3RyYXRlZ3kvTWF0Y2hTdHJhdGVneS5qYXZh) | `91.66% <91.66%> (ø)` | |
| [...ugin/base/condition/strategy/AndMatchStrategy.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3368/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vYmFzZS9jb25kaXRpb24vc3RyYXRlZ3kvQW5kTWF0Y2hTdHJhdGVneS5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../base/condition/strategy/MatchStrategyFactory.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3368/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vYmFzZS9jb25kaXRpb24vc3RyYXRlZ3kvTWF0Y2hTdHJhdGVneUZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...lugin/base/condition/strategy/OrMatchStrategy.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3368/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vYmFzZS9jb25kaXRpb24vc3RyYXRlZ3kvT3JNYXRjaFN0cmF0ZWd5LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ng/rocketmq/rocketmq/RocketMQLogCollectClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3368/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcvcm9ja2V0bXEvcm9ja2V0bXEvUm9ja2V0TVFMb2dDb2xsZWN0Q2xpZW50LmphdmE=) | `72.00% <0.00%> (-4.00%)` | :arrow_down: |
| [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3368/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `62.76% <0.00%> (-1.07%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3368?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3368?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d47e617...a87f188](https://codecov.io/gh/apache/incubator-shenyu/pull/3368?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] dragon-zhang commented on pull request #3368: [ISSUE #3367] selector match only once
Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on PR #3368:
URL: https://github.com/apache/incubator-shenyu/pull/3368#issuecomment-1119686370
see https://github.com/apache/incubator-shenyu/pull/3390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] dragon-zhang closed pull request #3368: [ISSUE #3367] selector match only once
Posted by GitBox <gi...@apache.org>.
dragon-zhang closed pull request #3368: [ISSUE #3367] selector match only once
URL: https://github.com/apache/incubator-shenyu/pull/3368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org