[jira] [Created] (MESOS-1378) Contender cancel should check whether the membership is already cancelled.

["Yan Xu (JIRA)" <ji...@apache.org>]

Yan Xu created MESOS-1378:
-----------------------------

             Summary: Contender cancel should check whether the membership is already cancelled.
                 Key: MESOS-1378
                 URL: https://issues.apache.org/jira/browse/MESOS-1378
             Project: Mesos
          Issue Type: Bug
            Reporter: Yan Xu
            Assignee: Yan Xu
            Priority: Minor


[LeaderContenderProcess::cancel()|https://github.com/apache/mesos/blob/4f97402d70f0f0936396cf5443ce545cf8e1c958/src/zookeeper/contender.cpp#L172] current attempts to cancel the membership even though the membership is already cancelled.

This causes Group to ask ZK to delete a path that is already gone, which is safe in the way group and contender are handling it but it produces the following confusing log lines (something is cancelled twice) and an unnecessary ZK call.

{noformat}
I0515 07:03:37.658303 45972 contender.cpp:192] Membership cancelled: 1322
I0515 07:03:37.658370 45983 master.cpp:903] Lost candidacy as a follower... Contend again
I0515 07:03:37.658455 45980 contender.cpp:211] Withdrawing the previous membership before recontending
2014-05-15 07:03:37,658:45966(0x7fcf934db940):ZOO_INFO@zookeeper_close@2522: Freeing zookeeper resources for sessionId=0x45feb12610105d

I0515 07:03:37.658691 45986 contender.cpp:182] Now cancelling the membership: 1322
{noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)