You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/08/16 23:08:29 UTC
Review Request 61704: Added CSI client classes to talk to CSI plugins.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61704/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: mesos-7491
https://issues.apache.org/jira/browse/mesos-7491
Repository: mesos
Description
-------
Added CSI client classes to talk to CSI plugins.
Diffs
-----
include/mesos/csi/csi.hpp PRE-CREATION
src/csi/csi.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/61704/diff/1/
Testing
-------
Tests described in r/61706.
Thanks,
Chun-Hung Hsiao
Re: Review Request 61704: Added CSI client classes to talk to CSI
plugins.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61704/#review183186
-----------------------------------------------------------
include/mesos/csi/csi.hpp
Lines 1 (patched)
<https://reviews.apache.org/r/61704/#comment259201>
I don't think we need to expose this header yet. Let's have the following layout:
```
src/csi/
|-- spec.hpp # just include <csi/csi.grpc.pb.h>
|-- client.hpp
```
Let's put the body of this file to `client.hpp`.
Also, I'd suggest we only have one client and embed the runtime (for now).
```
class mesos::csi::Client
{
public:
Client(const string& uri);
};
```
- Jie Yu
On Aug. 16, 2017, 11:08 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61704/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2017, 11:08 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: mesos-7491
> https://issues.apache.org/jira/browse/mesos-7491
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added CSI client classes to talk to CSI plugins.
>
>
> Diffs
> -----
>
> include/mesos/csi/csi.hpp PRE-CREATION
> src/csi/csi.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61704/diff/1/
>
>
> Testing
> -------
>
> Tests described in r/61706.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61704: Added CSI client classes to talk to CSI
plugins.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61704/#review183083
-----------------------------------------------------------
Bad patch!
Reviews applied: [61704, 61703, 61600]
Failed command: python support/apply-reviews.py -n -r 61703
Error:
error: missing binary patch data for '3rdparty/csi-0.1.0.tar.gz'
error: binary patch does not apply to '3rdparty/csi-0.1.0.tar.gz'
error: 3rdparty/csi-0.1.0.tar.gz: patch does not apply
Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/240/console
- Mesos Reviewbot Windows
On Aug. 16, 2017, 11:08 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61704/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2017, 11:08 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: mesos-7491
> https://issues.apache.org/jira/browse/mesos-7491
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added CSI client classes to talk to CSI plugins.
>
>
> Diffs
> -----
>
> include/mesos/csi/csi.hpp PRE-CREATION
> src/csi/csi.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61704/diff/1/
>
>
> Testing
> -------
>
> Tests described in r/61706.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61704: Added CSI client classes to talk to CSI
plugins.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61704/#review183196
-----------------------------------------------------------
include/mesos/csi/csi.hpp
Lines 60 (patched)
<https://reviews.apache.org/r/61704/#comment259213>
I'd prefer using `CreateVolume` instead of `createVolume`. We do have exceptions for things like this because this is an external interface. Consistency is more important.
Ditto on other interfaces.
- Jie Yu
On Aug. 16, 2017, 11:08 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61704/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2017, 11:08 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: mesos-7491
> https://issues.apache.org/jira/browse/mesos-7491
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added CSI client classes to talk to CSI plugins.
>
>
> Diffs
> -----
>
> include/mesos/csi/csi.hpp PRE-CREATION
> src/csi/csi.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61704/diff/1/
>
>
> Testing
> -------
>
> Tests described in r/61706.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61704: Added CSI client classes to talk to CSI
plugins.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61704/#review183513
-----------------------------------------------------------
Fix it, then Ship it!
src/csi/client.hpp
Lines 29 (patched)
<https://reviews.apache.org/r/61704/#comment259522>
We don't use `using namespace` in headers following google style guide.
- Jie Yu
On Aug. 19, 2017, 12:36 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61704/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2017, 12:36 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: mesos-7491
> https://issues.apache.org/jira/browse/mesos-7491
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added CSI client classes to talk to CSI plugins.
>
>
> Diffs
> -----
>
> src/csi/client.hpp PRE-CREATION
> src/csi/client.cpp PRE-CREATION
> src/csi/spec.hpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61704/diff/2/
>
>
> Testing
> -------
>
> Tests described in r/61706.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61704: Added CSI client classes to talk to CSI
plugins.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61704/
-----------------------------------------------------------
(Updated Aug. 19, 2017, 12:36 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
Addressed @jieyu's comments.
Bugs: mesos-7491
https://issues.apache.org/jira/browse/mesos-7491
Repository: mesos
Description
-------
Added CSI client classes to talk to CSI plugins.
Diffs (updated)
-----
src/csi/client.hpp PRE-CREATION
src/csi/client.cpp PRE-CREATION
src/csi/spec.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/61704/diff/2/
Changes: https://reviews.apache.org/r/61704/diff/1-2/
Testing
-------
Tests described in r/61706.
Thanks,
Chun-Hung Hsiao