[GitHub] [superset] kgabryje commented on pull request #19794: feat(explore): Rearrange controls in most popular charts

[GitBox <gi...@apache.org>]

kgabryje commented on PR #19794:
URL: https://github.com/apache/superset/pull/19794#issuecomment-1104978304

   1. After a discussion with @villebro we decided to stick with "Chart" for now
   2. As for Mixed Timeseries, that chart has a more complex control panel since we configure 2 queries - Query A and Query B. If we were to use the same pattern as in other charts in this PR, we'd have a structure `Query A, Filter A, Advanced query settings A, Query b, Filter B, Advanced query settings B` and that's not what we aim for. For that reason I'm going to leave it as it is for now and wait for design input. @kasiazjc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org