[GitHub] [arrow] kylepbit commented on a change in pull request #8581: ARROW-10441: [Java] Prevent closure of shared channels for FlightClient

[GitBox <gi...@apache.org>]

kylepbit commented on a change in pull request #8581:
URL: https://github.com/apache/arrow/pull/8581#discussion_r517097401



##########
File path: java/flight/flight-grpc/src/main/java/org/apache/arrow/flight/FlightGrpcUtils.java
##########
@@ -49,10 +143,10 @@ public static BindableService createFlightService(BufferAllocator allocator, Fli
   /**
    * Creates a Flight client.
    * @param incomingAllocator  Memory allocator
-   * @param channel provides a connection to a gRPC server
+   * @param channel provides a connection to a gRPC server. Will not be closed on closure of the returned FlightClient.

Review comment:
       To clarify, introduce a new method for creating flight clients which uses the proxy? To me that persists the issue that this was intended to solve, which is that closing a client closes the channel that was passed to it when that channel may be used to create multiple clients. Otherwise, I would suggest this simply be doc-fixed by noting that the client takes ownership and will close the channel upon closure.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org