You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/03/03 02:50:37 UTC

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8656: fs: Undefine CONFIG_FS_LARGEFILE if compiler doesn't support long long

xiaoxiang781216 commented on code in PR #8656:
URL: https://github.com/apache/nuttx/pull/8656#discussion_r1123976323


##########
include/nuttx/compiler.h:
##########
@@ -944,6 +944,10 @@
 
 #endif
 
+#ifndef CONFIG_HAVE_LONG_LONG
+#  undef CONFIG_FS_LARGEFILE
+#endif
+

Review Comment:
   Can not since HAVE_LONG_LONG isn't a Kconfig option, but define in:
   https://github.com/apache/nuttx/blob/master/include/nuttx/compiler.h#L283



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org