[GitHub] [airflow] ashb commented on a change in pull request #15781: Get rid of requests as core dependency

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #15781:
URL: https://github.com/apache/airflow/pull/15781#discussion_r632408316



##########
File path: UPDATING.md
##########
@@ -71,6 +71,20 @@ https://developers.google.com/style/inclusive-documentation
 
 -->
 
+### Connexion is now vendored in
+
+The `connexion` used for our REST API depends on `requests` library that's why we had to
+vendor it in (in `airflow/_vendor` package). Airflow does not depend on `connexion` any more.
+This is until `chardet` becomes an optional dependency of `requests`.
+
+See [PR to replace chardet with charset-normalizer](https://github.com/psf/requests/pull/5797)
+

Review comment:
       I don't think this is really relevant to users who are upgrading-- there is nothing they have to do with this information.
   
   
   ```suggestion
   ```

##########
File path: airflow/providers/google/cloud/hooks/cloud_sql.py
##########
@@ -500,7 +500,7 @@ def _download_sql_proxy_if_needed(self) -> None:
             )
         proxy_path_tmp = self.sql_proxy_path + ".tmp"
         self.log.info("Downloading cloud_sql_proxy from %s to %s", download_url, proxy_path_tmp)
-        response = requests.get(download_url, allow_redirects=True)
+        response = httpx.get(download_url, allow_redirects=True)

Review comment:
       `httpx` isn't listed in the google providers deps.
   
   Should it be?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org