You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Daniel Templeton (JIRA)" <ji...@apache.org> on 2016/10/18 23:03:58 UTC
[jira] [Commented] (YARN-5283) Refactor container assignment into
AbstractYarnScheduler#assignContainers
[ https://issues.apache.org/jira/browse/YARN-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586958#comment-15586958 ]
Daniel Templeton commented on YARN-5283:
----------------------------------------
Tiny quibbles:
{code}
/**
* Assigns containers based on the free resources available at the node.
* @param node The node to use for assigning containers
*/
{code}
should have a lover case 't' at the beginning of the parameter description.
{code}
/**
* Method determine whether assignContainers can be called.
* @returns true if the scheduler is cleared to call assignContainer().
*/
{code}
is missing something. Maybe, "method *to* determine...?" Also, the {{assignContainer()}} reference should be a link.
> Refactor container assignment into AbstractYarnScheduler#assignContainers
> -------------------------------------------------------------------------
>
> Key: YARN-5283
> URL: https://issues.apache.org/jira/browse/YARN-5283
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacity scheduler, fairscheduler, resourcemanager, scheduler
> Reporter: Ray Chiang
> Assignee: Ray Chiang
> Attachments: YARN-5283.001.patch, YARN-5283.002.patch
>
>
> CapacityScheduler#allocateContainersToNode() and FairScheduler#attemptScheduling() have some common code that can be refactored into a common abstract method like AbstractYarnScheduler#assignContainers().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org