You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by br...@apache.org on 2014/12/27 21:30:24 UTC
svn commit: r1648110 - in
/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats:
png/ psd/ rgbe/ tiff/ wbmp/ xbm/ xmp/ xpm/
Author: britter
Date: Sat Dec 27 20:30:24 2014
New Revision: 1648110
URL: http://svn.apache.org/r1648110
Log:
Use enhanced for loop
Modified:
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/png/PngWriteForceTrueColorText.java
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/psd/PsdReadTest.java
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/rgbe/RgbeReadTest.java
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/tiff/TiffReadTest.java
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/tiff/TiffRoundtripTest.java
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/wbmp/WbmpReadTest.java
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xbm/XbmReadTest.java
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xmp/XmpDumpTest.java
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xmp/XmpUpdateTest.java
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xpm/XpmReadTest.java
Modified: commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/png/PngWriteForceTrueColorText.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/png/PngWriteForceTrueColorText.java?rev=1648110&r1=1648109&r2=1648110&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/png/PngWriteForceTrueColorText.java (original)
+++ commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/png/PngWriteForceTrueColorText.java Sat Dec 27 20:30:24 2014
@@ -32,9 +32,8 @@ public class PngWriteForceTrueColorText
public void test() throws Exception {
final List<File> images = getPngImages();
- for (int i = 0; i < images.size(); i++) {
+ for (final File imageFile : images) {
- final File imageFile = images.get(i);
try {
if (isInvalidPNGTestFile(imageFile)) {
continue;
Modified: commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/psd/PsdReadTest.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/psd/PsdReadTest.java?rev=1648110&r1=1648109&r2=1648110&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/psd/PsdReadTest.java (original)
+++ commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/psd/PsdReadTest.java Sat Dec 27 20:30:24 2014
@@ -32,9 +32,8 @@ public class PsdReadTest extends PsdBase
Debug.debug("start");
final List<File> images = getPsdImages();
- for (int i = 0; i < images.size(); i++) {
+ for (final File imageFile : images) {
- final File imageFile = images.get(i);
Debug.debug("imageFile", imageFile);
final IImageMetadata metadata = Imaging.getMetadata(imageFile);
@@ -43,7 +42,7 @@ public class PsdReadTest extends PsdBase
final Map<String, Object> params = new HashMap<String, Object>();
final ImageInfo imageInfo = Imaging.getImageInfo(imageFile, params);
assertNotNull(imageInfo);
-
+
Imaging.getICCProfile(imageFile, params);
final BufferedImage image = Imaging.getBufferedImage(imageFile);
Modified: commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/rgbe/RgbeReadTest.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/rgbe/RgbeReadTest.java?rev=1648110&r1=1648109&r2=1648110&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/rgbe/RgbeReadTest.java (original)
+++ commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/rgbe/RgbeReadTest.java Sat Dec 27 20:30:24 2014
@@ -33,9 +33,8 @@ public class RgbeReadTest extends RgbeBa
final List<File> images = getRgbeImages();
- for (int i = 0; i < images.size(); i++) {
+ for (final File imageFile : images) {
- final File imageFile = images.get(i);
Debug.debug("imageFile", imageFile);
final IImageMetadata metadata = Imaging.getMetadata(imageFile);
Modified: commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/tiff/TiffReadTest.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/tiff/TiffReadTest.java?rev=1648110&r1=1648109&r2=1648110&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/tiff/TiffReadTest.java (original)
+++ commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/tiff/TiffReadTest.java Sat Dec 27 20:30:24 2014
@@ -30,16 +30,15 @@ public class TiffReadTest extends TiffBa
public void test() throws Exception {
final List<File> images = getTiffImages();
- for (int i = 0; i < images.size(); i++) {
+ for (final File imageFile : images) {
- final File imageFile = images.get(i);
Debug.debug("imageFile", imageFile);
final IImageMetadata metadata = Imaging.getMetadata(imageFile);
assertNotNull(metadata);
Debug.debug("ICC profile", Imaging.getICCProfile(imageFile));
-
+
final ImageInfo imageInfo = Imaging.getImageInfo(imageFile);
assertNotNull(imageInfo);
Modified: commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/tiff/TiffRoundtripTest.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/tiff/TiffRoundtripTest.java?rev=1648110&r1=1648109&r2=1648110&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/tiff/TiffRoundtripTest.java (original)
+++ commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/tiff/TiffRoundtripTest.java Sat Dec 27 20:30:24 2014
@@ -34,9 +34,8 @@ public class TiffRoundtripTest extends T
public void test() throws Exception {
final List<File> images = getTiffImages();
- for (int i = 0; i < images.size(); i++) {
+ for (final File imageFile : images) {
- final File imageFile = images.get(i);
Debug.debug("imageFile", imageFile);
final IImageMetadata metadata = Imaging.getMetadata(imageFile);
@@ -48,7 +47,7 @@ public class TiffRoundtripTest extends T
BufferedImage image = Imaging.getBufferedImage(imageFile);
assertNotNull(image);
- final int[] compressions = new int[] {
+ final int[] compressions = new int[]{
TiffConstants.TIFF_COMPRESSION_UNCOMPRESSED,
TiffConstants.TIFF_COMPRESSION_LZW,
TiffConstants.TIFF_COMPRESSION_PACKBITS
Modified: commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/wbmp/WbmpReadTest.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/wbmp/WbmpReadTest.java?rev=1648110&r1=1648109&r2=1648110&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/wbmp/WbmpReadTest.java (original)
+++ commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/wbmp/WbmpReadTest.java Sat Dec 27 20:30:24 2014
@@ -32,9 +32,8 @@ public class WbmpReadTest extends WbmpBa
Debug.debug("start");
final List<File> images = getWbmpImages();
- for (int i = 0; i < images.size(); i++) {
+ for (final File imageFile : images) {
- final File imageFile = images.get(i);
Debug.debug("imageFile", imageFile);
final IImageMetadata metadata = Imaging.getMetadata(imageFile);
Modified: commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xbm/XbmReadTest.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xbm/XbmReadTest.java?rev=1648110&r1=1648109&r2=1648110&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xbm/XbmReadTest.java (original)
+++ commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xbm/XbmReadTest.java Sat Dec 27 20:30:24 2014
@@ -32,9 +32,8 @@ public class XbmReadTest extends XbmBase
Debug.debug("start");
final List<File> images = getXbmImages();
- for (int i = 0; i < images.size(); i++) {
+ for (final File imageFile : images) {
- final File imageFile = images.get(i);
Debug.debug("imageFile", imageFile);
final IImageMetadata metadata = Imaging.getMetadata(imageFile);
Modified: commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xmp/XmpDumpTest.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xmp/XmpDumpTest.java?rev=1648110&r1=1648109&r2=1648110&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xmp/XmpDumpTest.java (original)
+++ commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xmp/XmpDumpTest.java Sat Dec 27 20:30:24 2014
@@ -28,9 +28,7 @@ public class XmpDumpTest extends Imaging
public void test() throws Exception {
final List<File> images = getTestImages();
- for (int i = 0; i < images.size(); i++) {
-
- final File imageFile = images.get(i);
+ for (final File imageFile : images) {
if (imageFile.getName().toLowerCase().endsWith(".png")
&& isInvalidPNGTestFile(imageFile)) {
Modified: commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xmp/XmpUpdateTest.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xmp/XmpUpdateTest.java?rev=1648110&r1=1648109&r2=1648110&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xmp/XmpUpdateTest.java (original)
+++ commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xmp/XmpUpdateTest.java Sat Dec 27 20:30:24 2014
@@ -33,9 +33,7 @@ public class XmpUpdateTest extends Imagi
public void test() throws Exception {
final List<File> images = getTestImages();
- for (int i = 0; i < images.size(); i++) {
-
- final File imageFile = images.get(i);
+ for (final File imageFile : images) {
if (imageFile.getName().toLowerCase().endsWith(".png")
&& isInvalidPNGTestFile(imageFile)) {
Modified: commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xpm/XpmReadTest.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xpm/XpmReadTest.java?rev=1648110&r1=1648109&r2=1648110&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xpm/XpmReadTest.java (original)
+++ commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/xpm/XpmReadTest.java Sat Dec 27 20:30:24 2014
@@ -32,9 +32,8 @@ public class XpmReadTest extends XpmBase
Debug.debug("start");
final List<File> images = getXpmImages();
- for (int i = 0; i < images.size(); i++) {
+ for (final File imageFile : images) {
- final File imageFile = images.get(i);
Debug.debug("imageFile", imageFile);
final IImageMetadata metadata = Imaging.getMetadata(imageFile);