You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jordan Birdsell (Code Review)" <ge...@cloudera.org> on 2018/06/22 14:57:16 UTC
[kudu-CR] KUDU-2382 - [examples] Add Kudu Basic Python Example
Jordan Birdsell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10794
Change subject: KUDU-2382 - [examples] Add Kudu Basic Python Example
......................................................................
KUDU-2382 - [examples] Add Kudu Basic Python Example
This patch adds a basic Kudu Python Client example to the
code base. This example also listed on the website.
Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
---
A examples/python/basic-python-example/README.md
A examples/python/basic-python-example/basic_example.py
2 files changed, 88 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/10794/1
--
To view, visit http://gerrit.cloudera.org:8080/10794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
Gerrit-Change-Number: 10794
Gerrit-PatchSet: 1
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
[kudu-CR] [examples] KUDU-2382: Add Kudu Basic Python Example
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, David Ribeiro Alves, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10794
to look at the new patch set (#4).
Change subject: [examples] KUDU-2382: Add Kudu Basic Python Example
......................................................................
[examples] KUDU-2382: Add Kudu Basic Python Example
This patch adds a basic Kudu Python Client example to the
code base. This example is also listed on the website.
Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
---
A examples/python/basic-python-example/README.md
A examples/python/basic-python-example/basic_example.py
2 files changed, 131 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/10794/4
--
To view, visit http://gerrit.cloudera.org:8080/10794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
Gerrit-Change-Number: 10794
Gerrit-PatchSet: 4
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [examples] KUDU-2382: Add Kudu Basic Python Example
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10794 )
Change subject: [examples] KUDU-2382: Add Kudu Basic Python Example
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
Gerrit-Change-Number: 10794
Gerrit-PatchSet: 7
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 05 Jul 2018 17:15:18 +0000
Gerrit-HasComments: No
[kudu-CR] [examples] KUDU-2382: Add Kudu Basic Python Example
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, David Ribeiro Alves, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10794
to look at the new patch set (#2).
Change subject: [examples] KUDU-2382: Add Kudu Basic Python Example
......................................................................
[examples] KUDU-2382: Add Kudu Basic Python Example
This patch adds a basic Kudu Python Client example to the
code base. This example is also listed on the website.
Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
---
A examples/python/basic-python-example/README.md
A examples/python/basic-python-example/basic_example.py
2 files changed, 103 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/10794/2
--
To view, visit http://gerrit.cloudera.org:8080/10794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
Gerrit-Change-Number: 10794
Gerrit-PatchSet: 2
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [examples] KUDU-2382: Add Kudu Basic Python Example
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, David Ribeiro Alves, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10794
to look at the new patch set (#5).
Change subject: [examples] KUDU-2382: Add Kudu Basic Python Example
......................................................................
[examples] KUDU-2382: Add Kudu Basic Python Example
This patch adds a basic Kudu Python Client example to the
code base. This example is also listed on the website.
Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
---
A examples/python/basic-python-example/README.md
A examples/python/basic-python-example/basic_example.py
2 files changed, 139 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/10794/5
--
To view, visit http://gerrit.cloudera.org:8080/10794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
Gerrit-Change-Number: 10794
Gerrit-PatchSet: 5
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [examples] KUDU-2382: Add Kudu Basic Python Example
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, David Ribeiro Alves, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10794
to look at the new patch set (#6).
Change subject: [examples] KUDU-2382: Add Kudu Basic Python Example
......................................................................
[examples] KUDU-2382: Add Kudu Basic Python Example
This patch adds a basic Kudu Python Client example to the
code base. This example is also listed on the website.
Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
---
A examples/python/basic-python-example/README.md
A examples/python/basic-python-example/basic_example.py
2 files changed, 139 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/10794/6
--
To view, visit http://gerrit.cloudera.org:8080/10794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
Gerrit-Change-Number: 10794
Gerrit-PatchSet: 6
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [examples] KUDU-2382: Add Kudu Basic Python Example
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10794 )
Change subject: [examples] KUDU-2382: Add Kudu Basic Python Example
......................................................................
[examples] KUDU-2382: Add Kudu Basic Python Example
This patch adds a basic Kudu Python Client example to the
code base. This example is also listed on the website.
Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
Reviewed-on: http://gerrit.cloudera.org:8080/10794
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
A examples/python/basic-python-example/README.md
A examples/python/basic-python-example/basic_example.py
2 files changed, 139 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Will Berkeley: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
Gerrit-Change-Number: 10794
Gerrit-PatchSet: 8
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [examples] KUDU-2382: Add Kudu Basic Python Example
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10794 )
Change subject: [examples] KUDU-2382: Add Kudu Basic Python Example
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/README.md
File examples/python/basic-python-example/README.md:
http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/README.md@24
PS4, Line 24: latest
maybe mention somehow that this points to the lastest build which is normally debug? people wanting to test kudu out should probably use a release build
http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/README.md@44
PS4, Line 44:
nit: extra space
http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/basic_example.py
File examples/python/basic-python-example/basic_example.py:
http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/basic_example.py@18
PS4, Line 18: import kudu
: from kudu.client import Partitioning
: from datetime import datetime
: import argparse
aside: maybe we should start enforcing some import discipline?
suggestion:
<sys imports>
<sys froms>
<lib imports>
<lib froms>
<project imports>
<project froms>
It not at leas order these alphabetically and separate import from froms
--
To view, visit http://gerrit.cloudera.org:8080/10794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
Gerrit-Change-Number: 10794
Gerrit-PatchSet: 4
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 25 Jun 2018 17:41:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2382 - [examples] Add Kudu Basic Python Example
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10794 )
Change subject: KUDU-2382 - [examples] Add Kudu Basic Python Example
......................................................................
Patch Set 1:
(12 comments)
Is there something used in the python world to specify dependencies and any build process? It'd be ideal if the basic example was self-contained, so if a user took the folder, copied it elsewhere, and started to use it as a basis for a Python application it'd be as easy as possible to get it running.
http://gerrit.cloudera.org:8080/#/c/10794/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10794/1//COMMIT_MSG@7
PS1, Line 7: KUDU-2382 - [examples]
nit: [examples] KUDU-2382: ...
http://gerrit.cloudera.org:8080/#/c/10794/1//COMMIT_MSG@10
PS1, Line 10:
nit: is
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/README.md
File examples/python/basic-python-example/README.md:
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/README.md@2
PS1, Line 2: Licensed under the Apache License, Version 2.0
Why does this license header differ from our standard one? Because it's not source code?
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py
File examples/python/basic-python-example/basic_example.py:
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@23
PS1, Line 23: kudu.master
This needs to be configurable so the example is runnable.
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@25
PS1, Line 25: # Define a schema for a new table
nit: End comments with a . here and below.
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@31
PS1, Line 31:
nit: add "the" or "its"
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@34
PS1, Line 34:
nit: a
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@51
PS1, Line 51: Updating
nit: Update
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@59
PS1, Line 59: capture
nit: extra word
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@62
PS1, Line 62: e
Is there anything worth printing in this object?
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@69
PS1, Line 69: Scanner
nit: scanner
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@71
PS1, Line 71: result = scanner.open().read_all_tuples()
We should print and/or verify the results are as expected.
--
To view, visit http://gerrit.cloudera.org:8080/10794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
Gerrit-Change-Number: 10794
Gerrit-PatchSet: 1
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 22 Jun 2018 15:29:47 +0000
Gerrit-HasComments: Yes
[kudu-CR] [examples] KUDU-2382: Add Kudu Basic Python Example
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10794 )
Change subject: [examples] KUDU-2382: Add Kudu Basic Python Example
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/basic_example.py
File examples/python/basic-python-example/basic_example.py:
http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/basic_example.py@18
PS4, Line 18: import kudu
: from kudu.client import Partitioning
: from datetime import datetime
: import argparse
> aside: maybe we should start enforcing some import discipline?
+1. Let's go further and pick an autoformatter.
--
To view, visit http://gerrit.cloudera.org:8080/10794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
Gerrit-Change-Number: 10794
Gerrit-PatchSet: 4
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 26 Jun 2018 18:07:29 +0000
Gerrit-HasComments: Yes
[kudu-CR] [examples] KUDU-2382: Add Kudu Basic Python Example
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10794 )
Change subject: [examples] KUDU-2382: Add Kudu Basic Python Example
......................................................................
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/README.md
File examples/python/basic-python-example/README.md:
http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/README.md@24
PS4, Line 24:
> maybe mention somehow that this points to the lastest build which is normal
Done
http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/README.md@44
PS4, Line 44:
> nit: extra space
Done
http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/basic_example.py
File examples/python/basic-python-example/basic_example.py:
http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/basic_example.py@18
PS4, Line 18: from datetime import datetime
: import argparse
:
: import kudu
> +1. Let's go further and pick an autoformatter.
This makes sense, ill start this as a separate thread. I've modified the order of the ones in this example though.
--
To view, visit http://gerrit.cloudera.org:8080/10794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
Gerrit-Change-Number: 10794
Gerrit-PatchSet: 5
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 26 Jun 2018 19:01:18 +0000
Gerrit-HasComments: Yes
[kudu-CR] [examples] KUDU-2382: Add Kudu Basic Python Example
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10794 )
Change subject: [examples] KUDU-2382: Add Kudu Basic Python Example
......................................................................
Patch Set 2:
(12 comments)
I added some basic documentation in the readme on how to install kudu (from source or from pypi). I think eventually we also want this documented elsewhere.
http://gerrit.cloudera.org:8080/#/c/10794/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10794/1//COMMIT_MSG@7
PS1, Line 7: [examples] KUDU-2382:
> nit: [examples] KUDU-2382: ...
Done
http://gerrit.cloudera.org:8080/#/c/10794/1//COMMIT_MSG@10
PS1, Line 10:
> nit: is
Done
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/README.md
File examples/python/basic-python-example/README.md:
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/README.md@2
PS1, Line 2: Licensed under the Apache License, Version 2.0
> Why does this license header differ from our standard one? Because it's not
Not sure, i copied this from one of the examples directories. Want me to change it?
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py
File examples/python/basic-python-example/basic_example.py:
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@23
PS1, Line 23:
> This needs to be configurable so the example is runnable.
Done
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@25
PS1, Line 25: parser.add_argument('--masters', '-m', nargs='+', default='localhost',
> nit: End comments with a . here and below.
Done
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@31
PS1, Line 31:
> nit: add "the" or "its"
Done
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@34
PS1, Line 34:
> nit: a
Done
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@51
PS1, Line 51: Open a t
> nit: Update
Done
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@59
PS1, Line 59:
> nit: extra word
Done
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@62
PS1, Line 62:
> Is there anything worth printing in this object?
No, removed it
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@69
PS1, Line 69: e a row
> nit: scanner
Done
http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@71
PS1, Line 71: session.apply(op)
> We should print and/or verify the results are as expected.
I added an example to print it and put a comment telling the user what the expected output is. I didn't think an assert would be all that valuable.
--
To view, visit http://gerrit.cloudera.org:8080/10794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
Gerrit-Change-Number: 10794
Gerrit-PatchSet: 2
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Sun, 24 Jun 2018 17:32:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] [examples] KUDU-2382: Add Kudu Basic Python Example
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, David Ribeiro Alves, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10794
to look at the new patch set (#3).
Change subject: [examples] KUDU-2382: Add Kudu Basic Python Example
......................................................................
[examples] KUDU-2382: Add Kudu Basic Python Example
This patch adds a basic Kudu Python Client example to the
code base. This example is also listed on the website.
Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
---
A examples/python/basic-python-example/README.md
A examples/python/basic-python-example/basic_example.py
2 files changed, 131 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/10794/3
--
To view, visit http://gerrit.cloudera.org:8080/10794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb
Gerrit-Change-Number: 10794
Gerrit-PatchSet: 3
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>