You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/18 15:20:31 UTC
[GitHub] [arrow] toddfarmer opened a new pull request, #13637: [Docs]: Standardize on arrow parent directory for build instructions
toddfarmer opened a new pull request, #13637:
URL: https://github.com/apache/arrow/pull/13637
The C++ and Python build instructions use the arrow parent directory ([example](https://arrow.apache.org/docs/developers/python.html#python-development)). The docs build instructions should do the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13637: [Docs]: Standardize on arrow parent directory for build instructions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13637:
URL: https://github.com/apache/arrow/pull/13637#issuecomment-1187647197
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13637: MINOR: [Docs] Standardize on arrow parent directory for build instructions
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13637:
URL: https://github.com/apache/arrow/pull/13637#discussion_r923719661
##########
docs/source/developers/documentation.rst:
##########
@@ -109,7 +109,8 @@ You can build documentation in a single directory without needing to install
all of the pre-requisites by installing sphinx, setting up a temporary
index in the directory you want to build and then building that directory.
-The example below shows how to do this in the ``developers`` directory.
+The example below shows how to do this in the ``arrow/docs/developers`` directory.
+The example below shows how to do this in the ``arrow/docs/developers`` directory.
Review Comment:
This sentence got duplicated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13637: MINOR: [Docs] Standardize on arrow parent directory for build instructions
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13637:
URL: https://github.com/apache/arrow/pull/13637#discussion_r923804973
##########
docs/source/developers/documentation.rst:
##########
@@ -109,7 +109,7 @@ You can build documentation in a single directory without needing to install
all of the pre-requisites by installing sphinx, setting up a temporary
index in the directory you want to build and then building that directory.
-The example below shows how to do this in the ``developers`` directory.
+The example below shows how to do this in the ``arrow/docs/developers`` directory.
Review Comment:
And possibly before L124/L130 below we should clarify that CWD is `arrow/docs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] toddfarmer commented on a diff in pull request #13637: MINOR: [Docs] Standardize on arrow parent directory for build instructions
Posted by GitBox <gi...@apache.org>.
toddfarmer commented on code in PR #13637:
URL: https://github.com/apache/arrow/pull/13637#discussion_r923773618
##########
docs/source/developers/documentation.rst:
##########
@@ -109,7 +109,8 @@ You can build documentation in a single directory without needing to install
all of the pre-requisites by installing sphinx, setting up a temporary
index in the directory you want to build and then building that directory.
-The example below shows how to do this in the ``developers`` directory.
+The example below shows how to do this in the ``arrow/docs/developers`` directory.
+The example below shows how to do this in the ``arrow/docs/developers`` directory.
Review Comment:
Thanks for noticing - removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13637: MINOR: [Docs] Standardize on arrow parent directory for build instructions
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13637:
URL: https://github.com/apache/arrow/pull/13637#issuecomment-1190362824
Benchmark runs are scheduled for baseline = a16ffa7324b0bbc8014d941d2a5eb8a9b3a91bb7 and contender = 8fe4ea522516840f49a34f615818cf482a58ca0f. 8fe4ea522516840f49a34f615818cf482a58ca0f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/547df8054e0440f7b3bec290f2bebd52...03f457a544934306bee1864fbdf2de56/)
[Failed :arrow_down:0.59% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/00621d45aaea4d4d91fd9ba9ad4559e0...0c3f3cf05076412fbba9f4c7988da2dd/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3eba750dc7d74d05a61eb28322e6280a...13cb66ae97074a6ea7250d040a690332/)
[Finished :arrow_down:0.36% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d4d8a515a2894d4aba9429e188ff8164...6c5a316fba084e89bc63782829a8a0e2/)
Buildkite builds:
[Failed] [`8fe4ea52` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1146)
[Failed] [`8fe4ea52` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1151)
[Failed] [`8fe4ea52` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1138)
[Finished] [`8fe4ea52` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1155)
[Failed] [`a16ffa73` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1145)
[Failed] [`a16ffa73` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1150)
[Failed] [`a16ffa73` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1137)
[Finished] [`a16ffa73` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1154)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13637: MINOR: [Docs] Standardize on arrow parent directory for build instructions
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13637:
URL: https://github.com/apache/arrow/pull/13637#discussion_r923804299
##########
docs/source/developers/documentation.rst:
##########
@@ -109,7 +109,7 @@ You can build documentation in a single directory without needing to install
all of the pre-requisites by installing sphinx, setting up a temporary
index in the directory you want to build and then building that directory.
-The example below shows how to do this in the ``developers`` directory.
+The example below shows how to do this in the ``arrow/docs/developers`` directory.
Review Comment:
Sorry, one other thing - this path doesn't actually exist, maybe it should be more like this?
```suggestion
The example below shows how to do this for the ``arrow/docs/source/developers`` directory.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #13637: MINOR: [Docs] Standardize on arrow parent directory for build instructions
Posted by GitBox <gi...@apache.org>.
lidavidm merged PR #13637:
URL: https://github.com/apache/arrow/pull/13637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org