[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #145: Derive gradle version from sbt

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #145:
URL: https://github.com/apache/incubator-pekko-grpc/pull/145#discussion_r1286132333


##########
gradle-plugin/build.gradle:
##########
@@ -2,17 +2,23 @@ plugins {
   id 'groovy'
   id 'java-gradle-plugin'
   id 'maven-publish'
-  id 'com.palantir.git-version' version '0.10.1'

Review Comment:
   This dependency is no longer needed, it was the gradle equivalent of `sbt-dynver` but as can be seen from the referenced github issue below it didn't even work properly which is explains all of the manual git calls



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org