You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "danny0405 (via GitHub)" <gi...@apache.org> on 2023/04/13 11:25:58 UTC

[GitHub] [hudi] danny0405 opened a new pull request, #8450: [HUDI-6073] Table create schema should not include metadata fields

danny0405 opened a new pull request, #8450:
URL: https://github.com/apache/hudi/pull/8450

   ### Change Logs
   
   Table create schema should not include metadata fields, this is the requisite for our `TableSchemaResolver`.
   
   ### Impact
   
   None
   
   ### Risk level (write none, low medium or high below)
   
   None
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] xiarixiaoyao commented on a diff in pull request #8450: [HUDI-6073] Table create schema should not include metadata fields

Posted by "xiarixiaoyao (via GitHub)" <gi...@apache.org>.
xiarixiaoyao commented on code in PR #8450:
URL: https://github.com/apache/hudi/pull/8450#discussion_r1165419086


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestCreateTable.scala:
##########
@@ -86,6 +87,14 @@ class TestCreateTable extends HoodieSparkSqlTestBase {
     assertResult(tableName)(tableConfig.getTableName)
     assertFalse(tableConfig.contains(OPERATION.key()))
 
+    val schemaOpt = tableConfig.getTableCreateSchema
+    assertTrue(schemaOpt.isPresent, "Table create schema should be persisted")
+    val noMetadataFields = schemaOpt.get().getFields.stream()
+      .noneMatch(new Predicate[Field] {
+        override def test(f: Field): Boolean = HoodieRecord.HOODIE_META_COLUMNS.contains(f.name())
+      })
+    assertTrue(noMetadataFields, "Table create schema should not include metadata fields")
+

Review Comment:
       assertFalse(schemaOpt.get().getFields.asScala.find(f => HoodieRecord.HOODIE_META_COLUMNS.contains(f.name())).isDefined,
         "Table create schema should not include metadata fields")



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8450: [HUDI-6073] Table create schema should not include metadata fields

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8450:
URL: https://github.com/apache/hudi/pull/8450#issuecomment-1506824246

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fd8641d8f762b47ad2a0721d406083deb7d23933",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16315",
       "triggerID" : "fd8641d8f762b47ad2a0721d406083deb7d23933",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fd8641d8f762b47ad2a0721d406083deb7d23933 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16315) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] danny0405 commented on pull request #8450: [HUDI-6073] Table create schema should not include metadata fields

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8450:
URL: https://github.com/apache/hudi/pull/8450#issuecomment-1508198443

   The failed test is flaky, it has been successful for the last run: https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=16315&view=results


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8450: [HUDI-6073] Table create schema should not include metadata fields

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8450:
URL: https://github.com/apache/hudi/pull/8450#issuecomment-1508052575

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fd8641d8f762b47ad2a0721d406083deb7d23933",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16315",
       "triggerID" : "fd8641d8f762b47ad2a0721d406083deb7d23933",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9e5ebaba08cf4176ef039298ee7719e50aba3d3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b9e5ebaba08cf4176ef039298ee7719e50aba3d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5433223d35c2216ef5d58c2705466bb8a0550a1c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16341",
       "triggerID" : "5433223d35c2216ef5d58c2705466bb8a0550a1c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b9e5ebaba08cf4176ef039298ee7719e50aba3d3 UNKNOWN
   * 5433223d35c2216ef5d58c2705466bb8a0550a1c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16341) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8450: [HUDI-6073] Table create schema should not include metadata fields

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8450:
URL: https://github.com/apache/hudi/pull/8450#issuecomment-1507843227

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fd8641d8f762b47ad2a0721d406083deb7d23933",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16315",
       "triggerID" : "fd8641d8f762b47ad2a0721d406083deb7d23933",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9e5ebaba08cf4176ef039298ee7719e50aba3d3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b9e5ebaba08cf4176ef039298ee7719e50aba3d3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fd8641d8f762b47ad2a0721d406083deb7d23933 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16315) 
   * b9e5ebaba08cf4176ef039298ee7719e50aba3d3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8450: [HUDI-6073] Table create schema should not include metadata fields

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8450:
URL: https://github.com/apache/hudi/pull/8450#issuecomment-1507853676

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fd8641d8f762b47ad2a0721d406083deb7d23933",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16315",
       "triggerID" : "fd8641d8f762b47ad2a0721d406083deb7d23933",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9e5ebaba08cf4176ef039298ee7719e50aba3d3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b9e5ebaba08cf4176ef039298ee7719e50aba3d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5433223d35c2216ef5d58c2705466bb8a0550a1c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16341",
       "triggerID" : "5433223d35c2216ef5d58c2705466bb8a0550a1c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fd8641d8f762b47ad2a0721d406083deb7d23933 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16315) 
   * b9e5ebaba08cf4176ef039298ee7719e50aba3d3 UNKNOWN
   * 5433223d35c2216ef5d58c2705466bb8a0550a1c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16341) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8450: [HUDI-6073] Table create schema should not include metadata fields

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8450:
URL: https://github.com/apache/hudi/pull/8450#issuecomment-1507848443

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fd8641d8f762b47ad2a0721d406083deb7d23933",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16315",
       "triggerID" : "fd8641d8f762b47ad2a0721d406083deb7d23933",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b9e5ebaba08cf4176ef039298ee7719e50aba3d3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b9e5ebaba08cf4176ef039298ee7719e50aba3d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5433223d35c2216ef5d58c2705466bb8a0550a1c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5433223d35c2216ef5d58c2705466bb8a0550a1c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fd8641d8f762b47ad2a0721d406083deb7d23933 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16315) 
   * b9e5ebaba08cf4176ef039298ee7719e50aba3d3 UNKNOWN
   * 5433223d35c2216ef5d58c2705466bb8a0550a1c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8450: [HUDI-6073] Table create schema should not include metadata fields

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8450:
URL: https://github.com/apache/hudi/pull/8450#issuecomment-1506811468

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fd8641d8f762b47ad2a0721d406083deb7d23933",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fd8641d8f762b47ad2a0721d406083deb7d23933",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fd8641d8f762b47ad2a0721d406083deb7d23933 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] danny0405 merged pull request #8450: [HUDI-6073] Table create schema should not include metadata fields

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8450:
URL: https://github.com/apache/hudi/pull/8450


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8450: [HUDI-6073] Table create schema should not include metadata fields

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8450:
URL: https://github.com/apache/hudi/pull/8450#issuecomment-1507170501

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fd8641d8f762b47ad2a0721d406083deb7d23933",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16315",
       "triggerID" : "fd8641d8f762b47ad2a0721d406083deb7d23933",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fd8641d8f762b47ad2a0721d406083deb7d23933 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16315) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org