You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/28 03:34:53 UTC

[GitHub] [spark] imback82 commented on a change in pull request #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens.

imback82 commented on a change in pull request #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens.
URL: https://github.com/apache/spark/pull/27027#discussion_r361773827
 
 

 ##########
 File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
 ##########
 @@ -95,15 +95,15 @@ statement
     : query                                                            #statementDefault
     | ctes? dmlStatementNoWith                                         #dmlStatement
     | USE NAMESPACE? multipartIdentifier                               #use
 
 Review comment:
   Should commands like `USE NAMESPACE` and `SHOW CURRENT NAMESPACE ` utilize `namespace`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org