You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/06 13:46:07 UTC

[GitHub] [tvm] xqdan edited a comment on pull request #7789: [TF frontend][bugfix]Avoid making a new node when already has span info

xqdan edited a comment on pull request #7789:
URL: https://github.com/apache/tvm/pull/7789#issuecomment-813992258


   > It is ok to me.
   > 
   > I guess this is caused by different nodes in PB are being parsed to the same Relay node, so they have different names.
   > 
   > I think EliminateCommonSubexpr() should be able to eliminate the redundancy, but it requires opt_level 3, so it is disabled by default.
   > 
   > https://github.com/apache/tvm/blob/813136401a11a49d6c15e6013c34dd822a5c4ff6/include/tvm/ir/transform.h#L88
   
   Yes，EliminateCommonSubexpr() can remove redundant operations, however better to fix at the very beginning.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org