You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/05 14:50:24 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #15671: Update example dag task to try more before failing

kaxil commented on a change in pull request #15671:
URL: https://github.com/apache/airflow/pull/15671#discussion_r626637577



##########
File path: airflow/example_dags/example_kubernetes_executor_config.py
##########
@@ -61,12 +61,17 @@ def test_volume_mount():
             """
             Tests whether the volume has been mounted.
             """
-            with open('/foo/volume_mount_test.txt', 'w') as foo:
-                foo.write('Hello')
-
-            return_code = os.system("cat /foo/volume_mount_test.txt")
-            if return_code != 0:
-                raise ValueError(f"Error when checking volume mount. Return code {return_code}")
+            for i in range(5):
+                try:

Review comment:
       We should not be running this DAG with any other executor as this is only an example to run it with kubernetes_executor and shows how to pass executor_config 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org