[jira] [Commented] (CASSANDRA-17997) Improve git branch handling for CircleCI generate.sh

["Andres de la Peña (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-17997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624688#comment-17624688 ] 

Andres de la Peña commented on CASSANDRA-17997:
-----------------------------------------------

I was planning on adding an option to specify the branch, for example {{{}generate.sh -b cassandra-3.11{}}}.

Note that [the {{BASE_BRANCH}} var|https://github.com/apache/cassandra/blob/trunk/.circleci/generate.sh#L21] can include a remote name, like in {{apache/cassandra-3.11}} or {{{}ASF/cassandra-3.11{}}}.

Note also that if we use a remote branch the remote should have been added first.
{quote}This may not be a local branch if the developer has recently cloned the repo and is creating a work branch
{quote}
I don't know how likely is that a developer creates a work branch that is not forked from a locally existing branch.

> Improve git branch handling for CircleCI generate.sh
> ----------------------------------------------------
>
>                 Key: CASSANDRA-17997
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17997
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Derek Chen-Becker
>            Assignee: Derek Chen-Becker
>            Priority: Normal
>
> The generate.sh script assumes a base git branch that is local and named after the official repo branch (e.g. `cassandra-3.11`). This may not be a local branch if the developer has recently cloned the repo and is creating a work branch, and will lead to the git commands in generate.sh failing:
>  
> ```
> fatal: ambiguous argument 'cassandra-3.11...HEAD': unknown revision or path not in the working tree.
> Use '--' to separate paths from revisions, like this:
> 'git <command> [<revision>...] -- [<file>...]'
> ```
> We should be able to make some sanity checks to better guide or warn the developer if things aren't set up properly to check against git.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org