You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Nick Dimiduk (JIRA)" <ji...@apache.org> on 2014/04/28 18:28:16 UTC
[jira] [Commented] (HBASE-11082) Potential unclosed TraceScope in
FSHLog#replaceWriter()
[ https://issues.apache.org/jira/browse/HBASE-11082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983164#comment-13983164 ]
Nick Dimiduk commented on HBASE-11082:
--------------------------------------
Oh, sorry [~rekhajoshm]. I didn't refresh the JIRA page, hadn't noticed you picked it up.
> Potential unclosed TraceScope in FSHLog#replaceWriter()
> -------------------------------------------------------
>
> Key: HBASE-11082
> URL: https://issues.apache.org/jira/browse/HBASE-11082
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.99.0
> Reporter: Ted Yu
> Assignee: Nick Dimiduk
> Priority: Minor
> Fix For: 0.99.0
>
> Attachments: HBASE-11082.00.patch
>
>
> In the finally block starting at line 924:
> {code}
> } finally {
> // Let the writer thread go regardless, whether error or not.
> if (zigzagLatch != null) {
> zigzagLatch.releaseSafePoint();
> // It will be null if we failed our wait on safe point above.
> if (syncFuture != null) blockOnSync(syncFuture);
> }
> scope.close();
> {code}
> If blockOnSync() throws IOException, the TraceScope would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)