You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/04 03:43:03 UTC
[GitHub] [spark] ulysses-you opened a new pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
ulysses-you opened a new pull request #31732:
URL: https://github.com/apache/spark/pull/31732
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add allow list to capture sql config for view.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Spark use origin text sql to store view then capture and store sql config into view metadata.
Capture config will skip some config with some prefix, e.g. `spark.sql.optimizer.` but unfortunately `spark.sql.optimizer.disableHints` is start with `spark.sql.optimizer.`.
We need a allow list to help capture the config.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes bug fix.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Add test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790608002
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790676297
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135750/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790597096
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135742/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #31732:
URL: https://github.com/apache/spark/pull/31732#discussion_r587233273
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
##########
@@ -909,4 +910,17 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils {
}
}
}
+
+ test("SPARK-34613: Fix view does not capture disable hint config") {
Review comment:
We don't use the `SQLConf.get` to do the view analysis, instead we use the `new SQLConf()`. So we always use the default value `false`. See some related code in `View` below
```
def effectiveSQLConf(configs: Map[String, String], isTempView: Boolean): SQLConf = {
val activeConf = SQLConf.get
// For temporary view, we always use captured sql configs
if (activeConf.useCurrentSQLConfigsForView && !isTempView) return activeConf
val sqlConf = new SQLConf()
for ((k, v) <- configs) {
sqlConf.settings.put(k, v)
}
sqlConf
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-791039959
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40361/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790597096
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135742/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31732:
URL: https://github.com/apache/spark/pull/31732#discussion_r587205784
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
##########
@@ -909,4 +910,17 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils {
}
}
}
+
+ test("SPARK-34613: Fix view does not capture disable hint config") {
Review comment:
does this test fail before? you did not change the config after the view creation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790608002
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40338/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31732:
URL: https://github.com/apache/spark/pull/31732#discussion_r587205467
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
##########
@@ -359,8 +359,13 @@ object ViewHelper {
"spark.sql.shuffle.",
"spark.sql.adaptive.")
+ private val configPrefixAllowList = Seq(
Review comment:
it's not prefix. probably just call it `configAllowList`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-791156434
thanks for merging !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790487524
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40325/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31732:
URL: https://github.com/apache/spark/pull/31732#discussion_r587423938
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewTestSuite.scala
##########
@@ -278,6 +279,19 @@ abstract class SQLViewTestSuite extends QueryTest with SQLTestUtils {
}
}
}
+
+ test("SPARK-34613: Fix view does not capture disable hint config") {
+ withSQLConf(DISABLE_HINTS.key -> "true") {
+ withView("v1") {
+ sql("CREATE VIEW v1 AS SELECT /*+ repartition(1) */ 1")
Review comment:
let's follow other tests in this suite and use `createView`, which can test all 3 different view types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790422772
**[Test build #135742 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135742/testReport)** for PR 31732 at commit [`8c9ff7f`](https://github.com/apache/spark/commit/8c9ff7fb0301552aaab8a696d51b97d71035d128).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-791134381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-791039044
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40358/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790487524
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40325/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790597718
**[Test build #135755 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135755/testReport)** for PR 31732 at commit [`271a2fb`](https://github.com/apache/spark/commit/271a2fb7ed093f9725eb89dcecf89cbaf83d34c5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-791025206
**[Test build #135776 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135776/testReport)** for PR 31732 at commit [`3a7999d`](https://github.com/apache/spark/commit/3a7999d00e653de8ae30b4b041bf959e3ee304b5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790422772
**[Test build #135742 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135742/testReport)** for PR 31732 at commit [`8c9ff7f`](https://github.com/apache/spark/commit/8c9ff7fb0301552aaab8a696d51b97d71035d128).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790498830
**[Test build #135750 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135750/testReport)** for PR 31732 at commit [`06012f0`](https://github.com/apache/spark/commit/06012f0ed4ceb3ca607b4b2436e3094ae919a024).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790498830
**[Test build #135750 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135750/testReport)** for PR 31732 at commit [`06012f0`](https://github.com/apache/spark/commit/06012f0ed4ceb3ca607b4b2436e3094ae919a024).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-791039946
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40361/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790446016
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135730/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-791037725
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40361/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-791039959
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40361/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790597718
**[Test build #135755 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135755/testReport)** for PR 31732 at commit [`271a2fb`](https://github.com/apache/spark/commit/271a2fb7ed093f9725eb89dcecf89cbaf83d34c5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-791039044
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40358/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790532890
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40333/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #31732:
URL: https://github.com/apache/spark/pull/31732#discussion_r587332115
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
##########
@@ -359,8 +359,13 @@ object ViewHelper {
"spark.sql.shuffle.",
"spark.sql.adaptive.")
+ private val configAllowList = Seq(
+ SQLConf.DISABLE_HINTS.key
+ )
+
private def shouldCaptureConfig(key: String): Boolean = {
Review comment:
Added the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790677045
**[Test build #135755 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135755/testReport)** for PR 31732 at commit [`271a2fb`](https://github.com/apache/spark/commit/271a2fb7ed093f9725eb89dcecf89cbaf83d34c5).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790315789
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40312/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790294079
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40312/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790655648
**[Test build #135750 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135750/testReport)** for PR 31732 at commit [`06012f0`](https://github.com/apache/spark/commit/06012f0ed4ceb3ca607b4b2436e3094ae919a024).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790270717
**[Test build #135730 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135730/testReport)** for PR 31732 at commit [`f47a791`](https://github.com/apache/spark/commit/f47a791603983382fab85af17aaf2d3f447465a7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790377228
cc @linhongliu-db
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790677357
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135755/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790589320
**[Test build #135742 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135742/testReport)** for PR 31732 at commit [`8c9ff7f`](https://github.com/apache/spark/commit/8c9ff7fb0301552aaab8a696d51b97d71035d128).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790455621
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40325/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790446016
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135730/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790560067
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-791019639
**[Test build #135779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135779/testReport)** for PR 31732 at commit [`7d12709`](https://github.com/apache/spark/commit/7d12709b9e0fa00b5c09fc02ba25d6989c5d64aa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #31732:
URL: https://github.com/apache/spark/pull/31732#discussion_r587332222
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
##########
@@ -909,4 +910,17 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils {
}
}
}
+
+ test("SPARK-34613: Fix view does not capture disable hint config") {
Review comment:
Moved
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-791141276
thanks, merging to master/3.1!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790481595
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40325/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31732:
URL: https://github.com/apache/spark/pull/31732#discussion_r587567851
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewTestSuite.scala
##########
@@ -278,6 +279,20 @@ abstract class SQLViewTestSuite extends QueryTest with SQLTestUtils {
}
}
}
+
+ test("SPARK-34613: Fix view does not capture disable hint config") {
+ withSQLConf(DISABLE_HINTS.key -> "true") {
+ withView("v1") {
+ val viewName = createView("v1", "SELECT /*+ repartition(1) */ 1")
+ assert(
+ sql("SELECT * FROM v1").queryExecution.analyzed.collect {
Review comment:
it should be `SELECT * FROM $viewName`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-791025206
**[Test build #135776 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135776/testReport)** for PR 31732 at commit [`3a7999d`](https://github.com/apache/spark/commit/3a7999d00e653de8ae30b4b041bf959e3ee304b5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31732:
URL: https://github.com/apache/spark/pull/31732#discussion_r587246554
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
##########
@@ -909,4 +910,17 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils {
}
}
}
+
+ test("SPARK-34613: Fix view does not capture disable hint config") {
Review comment:
ah I see, thanks for the explanation!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790537951
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40333/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-791019639
**[Test build #135779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135779/testReport)** for PR 31732 at commit [`7d12709`](https://github.com/apache/spark/commit/7d12709b9e0fa00b5c09fc02ba25d6989c5d64aa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790535251
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40332/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #31732:
URL: https://github.com/apache/spark/pull/31732#discussion_r587269472
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
##########
@@ -909,4 +910,17 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils {
}
}
}
+
+ test("SPARK-34613: Fix view does not capture disable hint config") {
Review comment:
Maybe need to make description more clear next time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31732:
URL: https://github.com/apache/spark/pull/31732#discussion_r587219273
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
##########
@@ -909,4 +910,17 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils {
}
}
}
+
+ test("SPARK-34613: Fix view does not capture disable hint config") {
Review comment:
But when we read the view, we are still under `withSQLConf(DISABLE_HINTS.key -> "true")`, isn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790270717
**[Test build #135730 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135730/testReport)** for PR 31732 at commit [`f47a791`](https://github.com/apache/spark/commit/f47a791603983382fab85af17aaf2d3f447465a7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790309021
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40312/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] linhongliu-db commented on a change in pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
linhongliu-db commented on a change in pull request #31732:
URL: https://github.com/apache/spark/pull/31732#discussion_r587272341
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
##########
@@ -359,8 +359,13 @@ object ViewHelper {
"spark.sql.shuffle.",
"spark.sql.adaptive.")
+ private val configAllowList = Seq(
+ SQLConf.DISABLE_HINTS.key
+ )
+
private def shouldCaptureConfig(key: String): Boolean = {
Review comment:
could you leave a comment to make the filtering rule clear? i.e. allowList has higher priority than denyList.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-791134381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #31732:
URL: https://github.com/apache/spark/pull/31732#discussion_r587210944
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
##########
@@ -909,4 +910,17 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils {
}
}
}
+
+ test("SPARK-34613: Fix view does not capture disable hint config") {
Review comment:
Yes it will fail. View just use the stored config to do anlysis. Before this fix, the config of disable hint can't be captured, then we would always use the default value `false`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790315789
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40312/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790425755
**[Test build #135730 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135730/testReport)** for PR 31732 at commit [`f47a791`](https://github.com/apache/spark/commit/f47a791603983382fab85af17aaf2d3f447465a7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790560061
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] linhongliu-db commented on a change in pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
linhongliu-db commented on a change in pull request #31732:
URL: https://github.com/apache/spark/pull/31732#discussion_r587273974
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
##########
@@ -909,4 +910,17 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils {
}
}
}
+
+ test("SPARK-34613: Fix view does not capture disable hint config") {
Review comment:
it should be better to move this to `SQLViewTestSuite`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790677357
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135755/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790551070
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40332/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31732:
URL: https://github.com/apache/spark/pull/31732
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-791130360
**[Test build #135779 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135779/testReport)** for PR 31732 at commit [`7d12709`](https://github.com/apache/spark/commit/7d12709b9e0fa00b5c09fc02ba25d6989c5d64aa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-790347004
cc @maropu @cloud-fan @HyukjinKwon thanks for review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31732: [SPARK-34613][SQL] Fix view does not capture disable hint config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31732:
URL: https://github.com/apache/spark/pull/31732#issuecomment-791123673
**[Test build #135776 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135776/testReport)** for PR 31732 at commit [`3a7999d`](https://github.com/apache/spark/commit/3a7999d00e653de8ae30b4b041bf959e3ee304b5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org